7904037: Make OutputFormatAdapter public #158
Conversation
* This enables Fibula to reuse the same class when it wants to redirect the output from the process to the JMH output. * This is useful for example when Fibula's PGO integration invokes native image to recreate the binary with the profiling information.
galderz
changed the title
|
👋 Welcome back galder! A progress list of the required criteria for merging this PR into |
|
Oh forgot, I'll create a CODETOOLS issue for each of these PRs, coming... |
|
❗ This change is not yet ready to be integrated. |
galderz
changed the title
galderz
changed the title
|
@galderz This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply issue a |
|
/touch |
|
@galderz The pull request is being re-evaluated and the inactivity timeout has been reset. |
|
@galderz This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply issue a |
|
/touch |
|
@galderz The pull request is being re-evaluated and the inactivity timeout has been reset. |
|
@galderz This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply issue a |
|
/touch |
|
@galderz The pull request is being re-evaluated and the inactivity timeout has been reset. |
|
/touch |
|
@galderz The pull request is being re-evaluated and the inactivity timeout has been reset. |
1 participant
This is the first in a series of PRs that I will be sending over the next few days, which make extending JMH to benchmark Java code running as GraalVM native images more easily. The codename for this extension is Fibula. It can still work without this PRs but without them the extension has to duplicate code that exists in JMH, which is not desirable.
In this PR, we make
OutputFormatAdapterpublic.Why do that? This enables Fibula to reuse the same class when it wants to redirect the output from the process to the JMH output. This is useful for example when Fibula's PGO integration invokes native image to recreate the binary with the profiling information, see galderz/fibula@20eaf64
Here is the PR list for reference:
Progress
Issue
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jmh.git pull/158/head:pull/158$ git checkout pull/158Update a local copy of the PR:
$ git checkout pull/158$ git pull https://git.openjdk.org/jmh.git pull/158/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 158View PR using the GUI difftool:
$ git pr show -t 158Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jmh/pull/158.diff
Using Webrev
Link to Webrev Comment