8297088: Update LCMS to 2.14

[kvergizova]

I'd like to backport it for parity with Oracle 8u.
11u patch applies almost cleanly, except for a license update in THIRD_PARTY_README instead of lcms.md.
I also fixed the file paths in UPDATING.txt instructions so that they match the paths in OpenJDK8.

GHA testing revealed no regressions, additionally tested manually with J2Ddemo.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• JDK-8297088 needs maintainer approval

Issue

• JDK-8297088: Update LCMS to 2.14 (Bug - P3 - Approved)

Reviewers

• Alexey Bakhtin (@alexeybakhtin - Committer)
• Andrew John Hughes (@gnu-andrew - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk8u-dev.git pull/677/head:pull/677
$ git checkout pull/677

Update a local copy of the PR:
$ git checkout pull/677
$ git pull https://git.openjdk.org/jdk8u-dev.git pull/677/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 677

View PR using the GUI difftool:
$ git pr show -t 677

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk8u-dev/pull/677.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back evergizova! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@kvergizova This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8297088: Update LCMS to 2.14

Reviewed-by: abakhtin, andrew

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 5 new commits pushed to the master branch:

• 9a1f0c6: 8364597: Replace THL A29 Limited with Tencent
• 2b36fc1: 8345358: Some DLL Files are missing Windows Properties
• 86ecd5b: 8154043: Fields not reachable anymore by tab-key, because of new tabbing behaviour of radio button groups.
• ... and 2 more: https://git.openjdk.org/jdk8u-dev/compare/3f2b6ffee4b2a077f5fc8e00d58bce906a80cca0...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@alexeybakhtin, @gnu-andrew) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[openjdk]

This backport pull request has now been updated with issue from the original commit.

[mlbridge]

Webrevs

• 01: Full - Incremental (6f31652b)
• 00: Full (7536819c)

[gnu-andrew]

Patch itself looks ok. Could you re-run the Windows x86_64 build? It seems to be failing in an odd way (failing to build FreeType) that I can't see is related to the change.

[kvergizova]

Patch itself looks ok. Could you re-run the Windows x86_64 build? It seems to be failing in an odd way (failing to build FreeType) that I can't see is related to the change.

@gnu-andrew, thanks for the review.
It looks like the problem with Windows builds were fixed by 41e6bf7

All builds have passed successfully after the merge, and the remaining test failures don't seem to be related to the backport:

• security/infra/java/security/cert/CertPathValidator/certification/CAInterop.java#actalisauthenticationrootca
• gc/concurrentMarkSweep/SystemGCOnForegroundCollector.java
• runtime/7158988/FieldMonitor.java

[gnu-andrew]

Patch itself looks ok. Could you re-run the Windows x86_64 build? It seems to be failing in an odd way (failing to build FreeType) that I can't see is related to the change.

@gnu-andrew, thanks for the review. It looks like the problem with Windows builds were fixed by 41e6bf7

All builds have passed successfully after the merge, and the remaining test failures don't seem to be related to the backport:

* security/infra/java/security/cert/CertPathValidator/certification/CAInterop.java#actalisauthenticationrootca

* gc/concurrentMarkSweep/SystemGCOnForegroundCollector.java

* runtime/7158988/FieldMonitor.java

Thanks for re-testing. It's good to hear that this fixed the build as the relationship between the two wasn't clear from the build failure.

8u482 is open now, so please apply for approval to get this in.

[gnu-andrew]

Issues with Windows build resolved.

[openjdk]

⚠️ @kvergizova This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

[kvergizova]

/approval request I'd like to backport this for parity with Oracle 8u.
11u patch applies almost cleanly, except for a license update in THIRD_PARTY_README instead of lcms.md.
No new issues found in GHA testing, additionally tested manually with J2Ddemo.

[openjdk]

@kvergizova
8297088: The approval request has been created successfully.

[mrserb]

No new issues found in GHA testing, additionally tested manually with J2Ddemo.

This is not enough test coverage, CMM tests are not part of GA testing, you need to run at least headless tests from the jdk_desktop group, or directly: java/awt/color* and sun/java2d/cmm*. This is applicable to all backports for lcms including 11u.

[kvergizova]

No new issues found in GHA testing, additionally tested manually with J2Ddemo.

This is not enough test coverage, CMM tests are not part of GA testing, you need to run at least headless tests from the jdk_desktop group, or directly: java/awt/color* and sun/java2d/cmm*. This is applicable to all backports for lcms including 11u.

Thanks, java/awt/color/* and sun/java2d/cmm/* tests passed successfully

[gnu-andrew]

Sorry for the delay in getting back to this.
/approve yes

[openjdk]

@gnu-andrew
8297088: The approval request has been approved.

[kvergizova]

/integrate

[openjdk]

@kvergizova
Your change (at version 6f31652) is now ready to be sponsored by a Committer.

[gnu-andrew]

/sponsor

[openjdk]

Going to push as commit 9a4bc2d.
Since your change was applied there have been 6 commits pushed to the master branch:

• 9948bd6: 8367115: [8u] Problem list CAInterop.java#actalisauthenticationrootca test
• 9a1f0c6: 8364597: Replace THL A29 Limited with Tencent
• 2b36fc1: 8345358: Some DLL Files are missing Windows Properties
• ... and 3 more: https://git.openjdk.org/jdk8u-dev/compare/3f2b6ffee4b2a077f5fc8e00d58bce906a80cca0...master

Your commit was automatically rebased without conflicts.

[openjdk]

@gnu-andrew @kvergizova Pushed as commit 9a4bc2d.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.