Skip to content

8185500: [TESTBUG] Add keywords headful/printer in java/awt and javax tests. #464

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 20 commits into from
Closed

8185500: [TESTBUG] Add keywords headful/printer in java/awt and javax tests. #464

wants to merge 20 commits into from

Conversation

yaqsun
Copy link
Contributor

@yaqsun yaqsun commented Mar 4, 2024 •
edited by openjdk bot
Loading

This backport has modified the following aspects:

  • there are 53 cases that do not exist:
    jdk/test/java/awt/Choice/ChoiceHiDpi/ChoiceTest.java
    jdk/test/java/awt/Dialog/NestedDialogs/Modal/NestedModalDialogTest.java
    jdk/test/java/awt/Dialog/NestedDialogs/Modeless/NestedModelessDialogTest.java
    jdk/test/java/awt/FileDialog/FileDialogIconTest/FileDialogIconTest.java
    jdk/test/java/awt/Focus/FocusTraversalPolicy/ButtonGroupLayoutTraversal/ButtonGroupLayoutTraversalTest.java
    jdk/test/java/awt/Focus/RequestFocusByCause/RequestFocusByCauseTest.java
    jdk/test/java/awt/Frame/8158918/SetExtendedState.java
    jdk/test/java/awt/Frame/DecoratedFrameInsets/DecoratedFrameInsetsTest.java
    jdk/test/java/awt/Frame/SetMaximizedBounds/MaximizedMovedWindow.java
    jdk/test/java/awt/FullScreen/CurrentDisplayModeTest/CurrentDisplayModeTest.java
    jdk/test/java/awt/GraphicsDevice/DisplayModes/CompareToXrandrTest.java
    jdk/test/java/awt/hidpi/properties/HiDPIPropertiesWindowsTest.java
    jdk/test/java/awt/image/multiresolution/Corrupted2XImageTest.java
    jdk/test/java/awt/keyboard/AllKeyCode/AllKeyCode.java
    jdk/test/java/awt/Robot/HiDPIMouseClick/HiDPIRobotMouseClick.java
    jdk/test/java/awt/Robot/HiDPIScreenCapture/HiDPIRobotScreenCaptureTest.java
    jdk/test/java/awt/Scrollbar/ScrollbarMouseWheelTest/ScrollbarMouseWheelTest.java
    jdk/test/java/awt/SplashScreen/MultiResolutionSplash/unix/UnixMultiResolutionSplashTest.java
    jdk/test/java/awt/TextArea/AutoScrollOnSelectAndAppend/AutoScrollOnSelectAndAppend.java
    jdk/test/java/awt/TextArea/OverScrollTest/OverScrollTest.java
    jdk/test/java/awt/TextField/OverScrollTest/OverScrollTest.java
    jdk/test/java/awt/Window/GetScreenLocation/GetScreenLocationTest.java
    jdk/test/java/awt/Window/SetWindowLocationByPlatformTest/SetWindowLocationByPlatformTest.java
    jdk/test/javax/swing/JButton/8151303/PressedIconTest.java
    jdk/test/javax/swing/JComboBox/8041909/ActionListenerExceptionTest.java
    jdk/test/javax/swing/JComboBox/WindowsComboBoxSize/WindowsComboBoxSizeTest.java
    jdk/test/javax/swing/JFileChooser/8010718/bug8010718.java
    jdk/test/javax/swing/JFileChooser/8152677/SelectAllFilesFilterTest.java
    jdk/test/javax/swing/JInternalFrame/6288609/TestJInternalFrameDispose.java
    jdk/test/javax/swing/JInternalFrame/8075314/bug8075314.java
    jdk/test/javax/swing/JInternalFrame/8145060/TestJInternalFrameMinimize.java
    jdk/test/javax/swing/JInternalFrame/8160248/JInternalFrameDraggingTest.java
    jdk/test/javax/swing/JInternalFrame/DockIconRepaint/DockIconRepaint.java
    jdk/test/javax/swing/JList/6567433/UpdateUIRecursionTest.java
    jdk/test/javax/swing/JList/8161483/Bug8161483.java
    jdk/test/javax/swing/JMenu/8067346/bug8067346.java
    jdk/test/javax/swing/JMenuItem/8139169/ScreenMenuBarInputTwice.java
    jdk/test/javax/swing/JMenuItem/8158566/CloseOnMouseClickPropertyTest.java
    jdk/test/javax/swing/JMenuItem/ActionListenerCalledTwice/ActionListenerCalledTwiceTest.java
    jdk/test/javax/swing/JMenuItem/ClickMenuTestManual/ClickMenuTestManual.java
    jdk/test/javax/swing/JOptionPane/8081019/bug8081019.java
    jdk/test/javax/swing/JTable/6567433/UpdateUIRecursionTest.java
    jdk/test/javax/swing/JTableHeader/6567433/UpdateUIRecursionTest.java
    jdk/test/javax/swing/JTextArea/ScrollbarFlicker/ScrollFlickerTest.java
    jdk/test/javax/swing/JTree/6567433/UpdateUIRecursionTest.java
    jdk/test/javax/swing/plaf/basic/6866751/bug6866751.java
    jdk/test/javax/swing/plaf/windows/6921687/bug6921687.java
    jdk/test/javax/swing/ProgressMonitor/ProgressMonitorEscapeKeyPress.java
    jdk/test/javax/swing/text/GlyphPainter2/6427244/bug6427244.java
    jdk/test/javax/swing/text/Utilities/8142966/SwingFontMetricsTest.java
    jdk/test/javax/swing/UI/UnninstallUIMemoryLeaks/UnninstallUIMemoryLeaks.java
    jdk/test/sun/awt/image/OffScreenImageSource/ImageConsumerUnregisterTest.java
    jdk/test/sun/java2d/xrender/HugeGradientTest.java
  • context conflicts are handled
    jdk/test/javax/swing/system/6799345/TestShutdown.java
    jdk/test/javax/swing/Security/6938813/bug6938813.java
    jdk/test/javax/swing/JComboBox/6567433/UpdateUIRecursionTest.java
    jdk/test/javax/swing/JTextArea/6940863/bug6940863.java
    jdk/test/javax/swing/JPopupMenu/7154841/bug7154841.java
    jdk/test/javax/swing/JInternalFrame/Test6325652.java
    jdk/test/javax/swing/JFrame/8016356/bug8016356.java
    jdk/test/javax/swing/JFileChooser/6817933/Test6817933.java
    jdk/test/javax/swing/JFileChooser/6713352/bug6713352.java
    jdk/test/javax/swing/JComponent/8043610/bug8043610.java
    jdk/test/java/awt/print/PrinterJob/PrintCrashTest.java
    jdk/test/java/awt/print/PrinterJob/Margins.java
    jdk/test/java/awt/image/multiresolution/MultiResolutionToolkitImageTest.java
    jdk/test/TEST.ROOT
    jdk/test/com/apple/eawt/DefaultMenuBar/DefaultMenuBarTest.java
    jdk/test/com/apple/laf/ScreenMenu/ScreenMenuMemoryLeakTest.java
    jdk/test/java/awt/Desktop/DesktopGtkLoadTest/DesktopGtkLoadTest.java
    jdk/test/java/awt/Dialog/CloseDialog/CloseDialogTest.java
    jdk/test/java/awt/EmbeddedFrame/DisplayChangedTest/DisplayChangedTest.java
    jdk/test/java/awt/EmbeddedFrame/EmbeddedFrameGrabTest/EmbeddedFrameGrabTest.java
    jdk/test/java/awt/EventDispatchThread/LoopRobustness/LoopRobustness.html
    jdk/test/java/awt/Focus/FocusEmbeddedFrameTest/FocusEmbeddedFrameTest.java
    jdk/test/java/awt/Frame/NormalToIconified/NormalToIconifiedTest.java
    jdk/test/java/awt/Frame/SetMaximizedBounds/SetMaximizedBounds.java
    jdk/test/java/awt/KeyboardFocusmanager/DefaultPolicyChange/DefaultPolicyChange_Swing.java
    jdk/test/java/awt/datatransfer/HTMLDataFlavors/HTMLDataFlavorTest.java
    jdk/test/java/awt/font/TextLayout/TestSinhalaChar.java
    jdk/test/java/awt/im/8041990/bug8041990.java
    jdk/test/java/awt/image/MultiResolutionImageTest.java
    jdk/test/javax/swing/ToolTipManager/7123767/bug7123767.java
  • context is adapted where needed

Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • JDK-8186259 needs maintainer approval
  • Commit message must refer to an issue
  • JDK-8185500 needs maintainer approval

Issues

  • JDK-8185500: [TESTBUG] Add keywords headful/printer in java/awt and javax tests. (Bug - P4 - Approved)
  • JDK-8186259: IOExceptionIfEncodedURLTest.sh versus IOExceptionIfEncodedURLTest.java (Bug - P1 - Approved)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk8u-dev.git pull/464/head:pull/464
$ git checkout pull/464

Update a local copy of the PR:
$ git checkout pull/464
$ git pull https://git.openjdk.org/jdk8u-dev.git pull/464/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 464

View PR using the GUI difftool:
$ git pr show -t 464

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk8u-dev/pull/464.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Mar 4, 2024

👋 Welcome back yaqsun! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 34afeced211cd7115e2529b043c1e57dfa1291fe 8185500: [TESTBUG] Add keywords headful/printer in java/awt and javax tests. Mar 4, 2024
@openjdk
Copy link

openjdk bot commented Mar 4, 2024

This backport pull request has now been updated with issue and summary from the original commit.

@openjdk openjdk bot added backport Port of a pull request already in a different code base rfr Pull request is ready for review labels Mar 4, 2024
@mlbridge
Copy link

mlbridge bot commented Mar 4, 2024 •
edited
Loading

Webrevs

@openjdk
Copy link

openjdk bot commented Mar 13, 2024 •
edited
Loading

@yaqsun This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8185500: [TESTBUG] Add keywords headful/printer in java/awt and javax tests.
8186259: IOExceptionIfEncodedURLTest.sh versus IOExceptionIfEncodedURLTest.java

Add new keyword 'printer'. Some minor test fixes to show headless exception. Add some @requires windows.

Reviewed-by: serb

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 97 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@mrserb) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@mrserb
Copy link
Member

mrserb commented Apr 1, 2024

the two cases no longer exist in the high version jdk, so backport is not performed
jdk/test/java/awt/appletviewer/IOExceptionIfEncodedURLTest/IOExceptionIfEncodedURLTest.java
jdk/test/java/awt/appletviewer/IOExceptionIfEncodedURLTest/IOExceptionIfEncodedURLTest.sh

The test is still there in the jdk8u-dev:

@yaqsun
Copy link
Contributor Author

yaqsun commented Apr 1, 2024 •
edited
Loading

the two cases no longer exist in the high version jdk, so backport is not performed
jdk/test/java/awt/appletviewer/IOExceptionIfEncodedURLTest/IOExceptionIfEncodedURLTest.java
jdk/test/java/awt/appletviewer/IOExceptionIfEncodedURLTest/IOExceptionIfEncodedURLTest.sh

The test is still there in the jdk8u-dev:

The above two cases have been backport.

@ktakakuri ktakakuri mentioned this pull request Apr 12, 2024
Closed
4 tasks
@yaqsun
Copy link
Contributor Author

yaqsun commented Apr 19, 2024 •
edited
Loading

security/infra/java/security/cert/CertPathValidator/certification/CAInterop.java#certignarootca always fail in test results.

@bridgekeeper
Copy link

bridgekeeper bot commented May 17, 2024

@yaqsun This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

mrserb
mrserb reviewed Jun 10, 2024
View reviewed changes
@bridgekeeper
Copy link

bridgekeeper bot commented Mar 27, 2025

@yaqsun This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

@mrserb
Copy link
Member

mrserb commented Mar 27, 2025

keep open

@bridgekeeper
Copy link

bridgekeeper bot commented Apr 25, 2025

@yaqsun This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

@mrserb
Copy link
Member

mrserb commented May 9, 2025

/integrate

@openjdk
Copy link

openjdk bot commented May 9, 2025

@mrserb Only the author (@yaqsun) is allowed to issue the integrate command.

@bridgekeeper
Copy link

bridgekeeper bot commented Jun 6, 2025

@yaqsun This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply issue a /touch or /keepalive command to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

@theaoqi
Copy link
Member

theaoqi commented Jun 9, 2025

/touch

@openjdk
Copy link

openjdk bot commented Jun 9, 2025

@theaoqi The pull request is being re-evaluated and the inactivity timeout has been reset.

@jerboaa
Copy link
Contributor

jerboaa commented Jun 10, 2025

This is pending integration by @yaqsun.

@bridgekeeper
Copy link

bridgekeeper bot commented Jul 8, 2025

@yaqsun This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply issue a /touch or /keepalive command to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

@theaoqi
Copy link
Member

theaoqi commented Jul 15, 2025

/touch

@openjdk
Copy link

openjdk bot commented Jul 15, 2025

@theaoqi The pull request is being re-evaluated and the inactivity timeout has been reset.

@bridgekeeper
Copy link

bridgekeeper bot commented Aug 12, 2025

@yaqsun This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply issue a /touch or /keepalive command to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

@theaoqi
Copy link
Member

theaoqi commented Aug 13, 2025

/touch

@openjdk
Copy link

openjdk bot commented Aug 13, 2025

@theaoqi The pull request is being re-evaluated and the inactivity timeout has been reset.

@mrserb
Copy link
Member

mrserb commented Aug 13, 2025

I think we may re-create this PR, so someone will be able to integrate it.

@mrserb
Copy link
Member

mrserb commented Aug 14, 2025

got a notification that it might be integrated by the end of the month, lets wait then.

@yaqsun
Copy link
Contributor Author

yaqsun commented Aug 26, 2025

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Aug 26, 2025
@openjdk
Copy link

openjdk bot commented Aug 26, 2025

@yaqsun
Your change (at version 8563895) is now ready to be sponsored by a Committer.

@yaqsun
Copy link
Contributor Author

yaqsun commented Aug 26, 2025

/sponsor

@openjdk
Copy link

openjdk bot commented Aug 26, 2025

@yaqsun Only Committers are allowed to sponsor changes.

@jerboaa
Copy link
Contributor

jerboaa commented Aug 26, 2025

/sponsor

@openjdk
Copy link

openjdk bot commented Aug 26, 2025

Going to push as commit cc30193.
Since your change was applied there have been 97 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Aug 26, 2025
@openjdk openjdk bot closed this Aug 26, 2025
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Aug 26, 2025
@openjdk
Copy link

openjdk bot commented Aug 26, 2025

@jerboaa @yaqsun Pushed as commit cc30193.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@mrserb mrserb mrserb approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
backport Port of a pull request already in a different code base integrated Pull request has been integrated
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@yaqsun @mrserb @jerboaa @theaoqi