Skip to content

Conversation

@Harshit470250
Copy link

@Harshit470250 Harshit470250 commented Oct 30, 2025

This pr adds the size of the match rule nodes.

There were a lot of nodes for which the size was variable, for those node I have taken the maximum possible size.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8370920: [s390] C2: add instruction size in s390.ad file (Enhancement - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/28054/head:pull/28054
$ git checkout pull/28054

Update a local copy of the PR:
$ git checkout pull/28054
$ git pull https://git.openjdk.org/jdk.git pull/28054/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 28054

View PR using the GUI difftool:
$ git pr show -t 28054

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/28054.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 30, 2025

👋 Welcome back Harshit470250! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Oct 30, 2025

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot changed the title JDK-8370920 8370920: [s390] C2: add instruction size in s390.ad file Oct 30, 2025
@openjdk
Copy link

openjdk bot commented Oct 30, 2025

⚠️ @Harshit470250 a branch with the same name as the source branch for this pull request (master) is present in the target repository. If you eventually integrate this pull request then the branch master in your personal fork will diverge once you sync your personal fork with the upstream repository.

To avoid this situation, create a new branch for your changes and reset the master branch. You can do this by running the following commands in a local repository for your personal fork. Note: you do not have to name the new branch NEW-BRANCH-NAME.

$ git checkout -b NEW-BRANCH-NAME
$ git branch -f master f3dfdfa3fdc97c2c850251d58f91134e0ae82240
$ git push -f origin master

Then proceed to create a new pull request with NEW-BRANCH-NAME as the source branch and close this one.

@openjdk
Copy link

openjdk bot commented Oct 30, 2025

@Harshit470250 The following label will be automatically applied to this pull request:

  • hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Oct 30, 2025
@mlbridge
Copy link

mlbridge bot commented Oct 30, 2025

Webrevs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

hotspot-compiler [email protected] rfr Pull request is ready for review

Development

Successfully merging this pull request may close these issues.

1 participant