8368739: [AIX] java/net/httpclient/http3/H3SimpleGet.java#useNioSelector and #with-continuations fail

[MBaesken]

After JDK-8349910 the 2 tests java/net/httpclient/http3/H3SimpleGet.java#useNioSelector and #with-continuations fail on AIX; all the other HTTP3 related tests seem to do fine on AIX.

The tests fail in the runs with -Djdk.httpclient.quic.defaultMTU=16336 . This setting has to be adjusted to a lower value for AIX to work.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8368739: [AIX] java/net/httpclient/http3/H3SimpleGet.java#useNioSelector and #with-continuations fail (Bug - P4)

Reviewers

• Martin Doerr (@TheRealMDoerr - Reviewer)
• Daniel Fuchs (@dfuch - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/28041/head:pull/28041
$ git checkout pull/28041

Update a local copy of the PR:
$ git checkout pull/28041
$ git pull https://git.openjdk.org/jdk.git pull/28041/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 28041

View PR using the GUI difftool:
$ git pr show -t 28041

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/28041.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back mbaesken! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@MBaesken This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8368739: [AIX] java/net/httpclient/http3/H3SimpleGet.java#useNioSelector and #with-continuations fail

Reviewed-by: mdoerr, dfuchs

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 17 new commits pushed to the master branch:

• 6080ccd: 8370797: Test runtime/ErrorHandling/AccessZeroNKlassHitsProtectionZone.java failed on macos 26
• 436dc68: 8367059: DTLS: loss of NewSessionTicket message results in handshake failure
• 28f2591: 8370568: Refer to Thread.interrupted as "interrupted status" consistently
• ... and 14 more: https://git.openjdk.org/jdk/compare/c97d50d793df46292e38707956586dfaa4b77d32...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@MBaesken The following label will be automatically applied to this pull request:

• net

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (d04ee58c)

[TheRealMDoerr]

LGTM. Thanks for fixing it!

[jaikiran]

Hello Matthias, I was talking to Daniel @dfuch yesterday and we were thinking of reducing the system property value (like you have it here). I thought he meant we would reduce it for all platforms and that way we wouldn't have to duplicate these test definitions for AIX.

It would be good to let Daniel have a look at this before integrating. You don't have to update the PR until you hear from Daniel.

[dfuch]

Hi Matthias - thanks for taking care of this one. This looks good. One alternative could have been to reduce the MTU to 8k uniformally, but what you are proposing is good. I am testing in our CI and will approve if I don't see any failure (and I don't expect this change would cause any).

[dfuch]

Tests are green

[MBaesken]

Thanks for the reviews !

/integrate

[openjdk]

Going to push as commit 5096dc8.
Since your change was applied there have been 21 commits pushed to the master branch:

• 17fd801: 8370807: G1: Improve region attribute table method naming
• 87a4772: 8366968: Exhaustive switch expression rejected by for not covering all possible values
• f3dfdfa: 8369013: Shenandoah: passive mode should support enabling ShenandoahCardBarrier
• ... and 18 more: https://git.openjdk.org/jdk/compare/c97d50d793df46292e38707956586dfaa4b77d32...master

Your commit was automatically rebased without conflicts.

[openjdk]

@MBaesken Pushed as commit 5096dc8.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.