Skip to content

8359248: JFR: Help text for-XX:StartFlightRecording:report-on-exit should explain option can be repeated #25885

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

egahlin
Copy link
Member

@egahlin egahlin commented Jun 18, 2025


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change requires CSR request JDK-8359271 to be approved

Issues

  • JDK-8359248: JFR: Help text for-XX:StartFlightRecording:report-on-exit should explain option can be repeated (Bug - P3)
  • JDK-8359271: JFR: Help text for-XX:StartFlightRecording:report-on-exit should explain option can be repeated (CSR)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/25885/head:pull/25885
$ git checkout pull/25885

Update a local copy of the PR:
$ git checkout pull/25885
$ git pull https://git.openjdk.org/jdk.git pull/25885/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 25885

View PR using the GUI difftool:
$ git pr show -t 25885

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/25885.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jun 18, 2025

👋 Welcome back egahlin! A progress list of the required criteria for merging this PR into jdk25 will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jun 18, 2025

@egahlin This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8359248: JFR: Help text for-XX:StartFlightRecording:report-on-exit should explain option can be repeated

Reviewed-by: mgronlun

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the jdk25 branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the jdk25 branch, type /integrate in a new comment.

@openjdk openjdk bot changed the title Backport fedd0a0ee3aea9f73cfce34172a764e63c1ba46b 8359248: JFR: Help text for-XX:StartFlightRecording:report-on-exit should explain option can be repeated Jun 18, 2025
@openjdk
Copy link

openjdk bot commented Jun 18, 2025

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required labels Jun 18, 2025
@openjdk
Copy link

openjdk bot commented Jun 18, 2025

@egahlin The following label will be automatically applied to this pull request:

  • hotspot-jfr

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@egahlin egahlin marked this pull request as ready for review June 18, 2025 20:39
@openjdk openjdk bot added the rfr Pull request is ready for review label Jun 18, 2025
@mlbridge
Copy link

mlbridge bot commented Jun 18, 2025

Webrevs

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jun 19, 2025
@egahlin
Copy link
Member Author

egahlin commented Jun 19, 2025

/integrate

@openjdk
Copy link

openjdk bot commented Jun 19, 2025

Going to push as commit b79ca5f.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jun 19, 2025
@openjdk openjdk bot closed this Jun 19, 2025
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jun 19, 2025
@openjdk
Copy link

openjdk bot commented Jun 19, 2025

@egahlin Pushed as commit b79ca5f.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required hotspot-jfr [email protected] integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

2 participants