Skip to content

8358686: CDS and AOT can cause buffer truncation warning even when logging is disabled #25866

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

mur47x111
Copy link
Contributor

@mur47x111 mur47x111 commented Jun 18, 2025

When CDS and AOT loggings are disabled, HotSpot may still warn about Mismatched values for property jdk.module.addexports:. This warn message could be large and exceeds the current logging buffer length, and it leads to a non-informative message:

Java HotSpot(TM) 64-Bit Server VM warning: outputStream::do_vsnprintf output truncated -- buffer length is 2000 bytes but 4276 bytes are needed.

This PR skips reporting loading error when CDS and AOT loggings are disabled.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8358686: CDS and AOT can cause buffer truncation warning even when logging is disabled (Bug - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/25866/head:pull/25866
$ git checkout pull/25866

Update a local copy of the PR:
$ git checkout pull/25866
$ git pull https://git.openjdk.org/jdk.git pull/25866/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 25866

View PR using the GUI difftool:
$ git pr show -t 25866

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/25866.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jun 18, 2025

👋 Welcome back yzheng! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jun 18, 2025

@mur47x111 This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8358686: CDS and AOT can cause buffer truncation warning even when logging is disabled

Reviewed-by: dnsimon, iklam

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 12 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the rfr Pull request is ready for review label Jun 18, 2025
@openjdk
Copy link

openjdk bot commented Jun 18, 2025

@mur47x111 The following label will be automatically applied to this pull request:

  • hotspot-runtime

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@mlbridge
Copy link

mlbridge bot commented Jun 18, 2025

Webrevs

Copy link
Member

@dougxc dougxc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jun 18, 2025
Copy link
Member

@iklam iklam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mur47x111
Copy link
Contributor Author

Thanks for the reviews! Passed tier1-3
/integrate

@mur47x111
Copy link
Contributor Author

/integrate

@openjdk
Copy link

openjdk bot commented Jun 19, 2025

Going to push as commit 2e3bdec.
Since your change was applied there have been 19 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jun 19, 2025
@openjdk openjdk bot closed this Jun 19, 2025
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jun 19, 2025
@openjdk
Copy link

openjdk bot commented Jun 19, 2025

@mur47x111 Pushed as commit 2e3bdec.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@openjdk
Copy link

openjdk bot commented Jun 19, 2025

@mur47x111 The command integrate can only be used in open pull requests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-runtime [email protected] integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

3 participants