8357987: [JVMCI] Add support for retrieving all methods of a ResolvedJavaType #25498

teshull · 2025-05-28T15:55:39Z

Currently from ResolvedJavaType one can retrieve all declared methods, static methods, and constructors of the given type. However, internally in HotSpot there are also VM-internal methods, such as overpass methods, associated with a given type which we cannot access via the API.

To correct this, we should add a new method which enables VM-internal methods, such as overpass methods, to be accessed.

Progress

Change must be properly reviewed (1 review required, with at least 1 Reviewer)
Change must not contain extraneous whitespace
Commit message must refer to an issue

Issue

JDK-8357987: [JVMCI] Add support for retrieving all methods of a ResolvedJavaType (Enhancement - P4)

Reviewers

Doug Simon (@dougxc - Reviewer)
Yudi Zheng (@mur47x111 - Committer)
Tom Rodriguez (@tkrodriguez - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/25498/head:pull/25498
$ git checkout pull/25498

Update a local copy of the PR:
$ git checkout pull/25498
$ git pull https://git.openjdk.org/jdk.git pull/25498/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 25498

View PR using the GUI difftool:
$ git pr show -t 25498

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/25498.diff

Using Webrev

Link to Webrev Comment

bridgekeeper · 2025-05-28T15:56:28Z

Hi @teshull, welcome to this OpenJDK project and thanks for contributing!

We do not recognize you as Contributor and need to ensure you have signed the Oracle Contributor Agreement (OCA). If you have not signed the OCA, please follow the instructions. Please fill in your GitHub username in the "Username" field of the application. Once you have signed the OCA, please let us know by writing /signed in a comment in this pull request.

If you already are an OpenJDK Author, Committer or Reviewer, please click here to open a new issue so that we can record that fact. Please use "Add GitHub user teshull" as summary for the issue.

If you are contributing this work on behalf of your employer and your employer has signed the OCA, please let us know by writing /covered in a comment in this pull request.

openjdk · 2025-05-28T15:56:30Z

@teshull This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8357987: [JVMCI] Add support for retrieving all methods of a ResolvedJavaType

Reviewed-by: dnsimon, yzheng, never

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 5 new commits pushed to the master branch:

a44a470: 8358515: make cmp-baseline is broken after JDK-8349665
cc11b7d: 8356128: Correct documentation for --linux-package-deps
406f1bc: 8357650: ThreadSnapshot to take snapshot of thread for thread dumps
... and 2 more: https://git.openjdk.org/jdk/compare/c382da579884c28f2765b2c6ba68c0ad4fdcb2ce...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@dougxc, @mur47x111, @tkrodriguez) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

openjdk · 2025-05-28T15:56:57Z

@teshull The following labels will be automatically applied to this pull request:

graal
hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

teshull · 2025-05-28T15:57:12Z

/covered

bridgekeeper · 2025-05-28T15:57:50Z

Thank you! Please allow for a few business days to verify that your employer has signed the OCA. Also, please note that pull requests that are pending an OCA check will not usually be evaluated, so your patience is appreciated!

src/jdk.internal.vm.ci/share/classes/jdk/vm/ci/meta/ResolvedJavaMethod.java

src/jdk.internal.vm.ci/share/classes/jdk/vm/ci/hotspot/HotSpotResolvedJavaMethodImpl.java

dougxc · 2025-05-28T17:51:03Z

src/jdk.internal.vm.ci/share/classes/jdk/vm/ci/hotspot/HotSpotResolvedJavaMethodImpl.java

+        if (isConstructor() || isStatic()) {
+            return false;
+        }
+        return !compilerToVM().isOverpass(this);


I think you can do this with a direct flag check:

boolean isOverpass = (getConstMethodFlags() & config().constMethodIsOverpass) != 0; return isOverpass;

See #20256 as an example of the other changes needed for this.

good call. changed

dougxc · 2025-05-28T17:52:03Z

src/jdk.internal.vm.ci/share/classes/jdk/vm/ci/meta/ResolvedJavaType.java

    }

+    /**
+     * Returns a list containing all the non-static methods present within this type.


Point out that the returned list is unmodifiable (like the API for Stream.toList() does).

src/jdk.internal.vm.ci/share/classes/jdk/vm/ci/hotspot/CompilerToVM.java

dougxc · 2025-05-28T17:54:27Z

src/jdk.internal.vm.ci/share/classes/jdk/vm/ci/hotspot/CompilerToVM.java

    native ResolvedJavaMethod[] getDeclaredMethods(HotSpotResolvedObjectTypeImpl klass, long klassPointer);

+    /**
+     * Gets the {@link ResolvedJavaMethod}s for all instance methods of {@code klass}.


instance -> non-static
Instance -> NonStatic

I realized NonStatic is not accurate - we return everything except <init>s and <clinit> - so I switched to NonInitializerMethods everywhere. Does that seem fair?

thinking about it more, it's probably better if we do no filtering and return all methods in InstanceKlass->_methods. How about something like getAllMethods:

/** * Returns a list containing all methods present within this type. This list can include * methods implicitly created and used by the VM. * The returned List is unmodifiable; calls to any mutator method * will always cause {@code UnsupportedOperationException} to be thrown. * * @param forceLink if {@code true}, forces this type to be {@link #link linked} */ List<ResolvedJavaMethod> getAllMethods(boolean forceLink);

Yes, that's a good idea - it's more future proof and lets the caller do the filtering.

This list can include methods implicitly created and used by the VM that are not present in {@link #getDeclaredMethods}.

I changed it now to be getAllMethods

dougxc · 2025-05-29T09:41:09Z

src/jdk.internal.vm.ci/share/classes/jdk/vm/ci/hotspot/CompilerToVM.java


    private native boolean isCompilable(HotSpotResolvedJavaMethodImpl method, long methodPointer);

+    /**


Delete this method - it's no longer used.

dougxc · 2025-05-29T09:41:28Z

src/hotspot/share/jvmci/jvmciCompilerToVM.cpp

  return !method->is_not_compilable(CompLevel_full_optimization);
 C2V_END

+C2V_VMENTRY_0(jboolean, isOverpass,(JNIEnv* env, jobject, ARGUMENT_PAIR(method)))


Delete this method - it's no longer used.

dougxc · 2025-05-29T09:41:37Z

src/hotspot/share/jvmci/jvmciCompilerToVM.cpp

  {CC "methodIsIgnoredBySecurityStackWalk",           CC "(" HS_METHOD2 ")Z",                                                               FN_PTR(methodIsIgnoredBySecurityStackWalk)},
  {CC "setNotInlinableOrCompilable",                  CC "(" HS_METHOD2 ")V",                                                               FN_PTR(setNotInlinableOrCompilable)},
  {CC "isCompilable",                                 CC "(" HS_METHOD2 ")Z",                                                               FN_PTR(isCompilable)},
+  {CC "isOverpass",                                   CC "(" HS_METHOD2 ")Z",                                                               FN_PTR(isOverpass)},


dougxc · 2025-05-30T08:49:10Z

...g/compiler/jvmci/jdk.vm.ci.runtime.test/src/jdk/vm/ci/runtime/test/TestResolvedJavaType.java

+        for (Class<?> c : classes) {
+            ResolvedJavaType type = metaAccess.lookupJavaType(c);
+            Set<ResolvedJavaMethod> allMethods = new HashSet<>(type.getAllMethods(true));
+            boolean included = Arrays.stream(type.getDeclaredMethods()).allMatch(m -> allMethods.contains(m));


You can produce a more helpful error message by collecting the entries from getDeclaredMethods, getDeclaredConstructors and the class initialized that are not in allMethods.

dougxc · 2025-05-30T08:51:01Z

I also updated the title of https://bugs.openjdk.org/browse/JDK-8357987 to Not Be All Capitalized so you'll need to fix the title of this PR.

mlbridge · 2025-05-30T15:06:04Z

Webrevs

dougxc

Looks good to me.

mur47x111 · 2025-06-02T12:07:42Z

src/jdk.internal.vm.ci/share/classes/jdk/vm/ci/hotspot/HotSpotResolvedObjectTypeImpl.java

+        if (instanceMethods.length == 0) {
+            return List.of();
+        }
+        return Collections.unmodifiableList(Arrays.asList(instanceMethods));


return List.of(instanceMethods); should work. We can then replace the above with return List.of(runtime().compilerToVm.getAllMethods(this));

dougxc

Still looks good to me.

tkrodriguez

Looks good.

teshull · 2025-06-03T19:34:01Z

/integrate

openjdk · 2025-06-03T19:35:19Z

@teshull
Your change (at version 606f361) is now ready to be sponsored by a Committer.

dougxc · 2025-06-03T19:37:17Z

/sponsor

openjdk · 2025-06-03T19:39:00Z

Going to push as commit e235b61.
Since your change was applied there have been 5 commits pushed to the master branch:

a44a470: 8358515: make cmp-baseline is broken after JDK-8349665
cc11b7d: 8356128: Correct documentation for --linux-package-deps
406f1bc: 8357650: ThreadSnapshot to take snapshot of thread for thread dumps
... and 2 more: https://git.openjdk.org/jdk/compare/c382da579884c28f2765b2c6ba68c0ad4fdcb2ce...master

Your commit was automatically rebased without conflicts.

openjdk · 2025-06-03T19:39:11Z

@dougxc @teshull Pushed as commit e235b61.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Add Support for Retrieving All Non-Static Methods of a ResolvedJavaType.

b1ddda0

bridgekeeper bot added the oca Needs verification of OCA signatory status label May 28, 2025

openjdk bot added graal [email protected] hotspot-compiler [email protected] labels May 28, 2025

bridgekeeper bot added the oca-verify Needs verification of OCA signatory status label May 28, 2025

teshull changed the title ~~8357987: [JVMCI] Add Support for Retrieving All Non-Static Methods of a ResolvedJavaType.~~ 8357987: [JVMCI] Add Support for Retrieving All Non-Static Methods of a ResolvedJavaType May 28, 2025

openjdk bot changed the title ~~8357987: [JVMCI] Add Support for Retrieving All Non-Static Methods of a ResolvedJavaType~~ 8357987: [JVMCI] Add Support for Retrieving All Non-Static Methods of a ResolvedJavaType. May 28, 2025

dougxc reviewed May 28, 2025

View reviewed changes

address reviewer feedback

412b1fe

teshull changed the title ~~8357987: [JVMCI] Add Support for Retrieving All Non-Static Methods of a ResolvedJavaType.~~ 8357987: [JVMCI] Add Support for Retrieving All Non-Static Methods of a ResolvedJavaType May 28, 2025

openjdk bot changed the title ~~8357987: [JVMCI] Add Support for Retrieving All Non-Static Methods of a ResolvedJavaType~~ 8357987: [JVMCI] Add Support for Retrieving All Non-Static Methods of a ResolvedJavaType. May 28, 2025

dougxc reviewed May 29, 2025

View reviewed changes

implement getAllMethods

1f42f05

dougxc reviewed May 30, 2025

View reviewed changes

bridgekeeper bot removed oca Needs verification of OCA signatory status oca-verify Needs verification of OCA signatory status labels May 30, 2025

openjdk bot added the rfr Pull request is ready for review label May 30, 2025

format javadoc and update test

0de1fea

teshull changed the title ~~8357987: [JVMCI] Add Support for Retrieving All Non-Static Methods of a ResolvedJavaType.~~ 8357987: [JVMCI] Add support for retrieving al methods of a ResolvedJavaType Jun 2, 2025

teshull changed the title ~~8357987: [JVMCI] Add support for retrieving al methods of a ResolvedJavaType~~ 8357987: [JVMCI] Add support for retrieving all methods of a ResolvedJavaType Jun 2, 2025

dougxc approved these changes Jun 2, 2025

View reviewed changes

openjdk bot added the ready Pull request is ready to be integrated label Jun 2, 2025

mur47x111 reviewed Jun 2, 2025

View reviewed changes

return List.of() from getAllMethods

ae81d46

openjdk bot removed the ready Pull request is ready to be integrated label Jun 2, 2025

dougxc approved these changes Jun 3, 2025

View reviewed changes

openjdk bot added the ready Pull request is ready to be integrated label Jun 3, 2025

mur47x111 approved these changes Jun 3, 2025

View reviewed changes

graalvmbot mentioned this pull request Jun 3, 2025

[JDK-8358544] Adapt "JDK-8357987: [JVMCI] Add support for retrieving all methods of a ResolvedJavaType" oracle/graal#11320

Merged

Merge remote-tracking branch 'origin/master' into JDK-8357987

606f361

tkrodriguez approved these changes Jun 3, 2025

View reviewed changes

openjdk bot added the sponsor Pull request is ready to be sponsored label Jun 3, 2025

openjdk bot added the integrated Pull request has been integrated label Jun 3, 2025

openjdk bot closed this Jun 3, 2025

openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Jun 3, 2025

graalvmbot mentioned this pull request Jun 10, 2025

[GR-65610] Update labsjdk to 25+26-jvmci-b01 oracle/graal#11374

Merged


		private native boolean isCompilable(HotSpotResolvedJavaMethodImpl method, long methodPointer);

		/**

8357987: [JVMCI] Add support for retrieving all methods of a ResolvedJavaType #25498

8357987: [JVMCI] Add support for retrieving all methods of a ResolvedJavaType #25498

Uh oh!

Conversation

teshull commented May 28, 2025 • edited by openjdk bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Progress

Issue

Reviewers

Reviewing

Uh oh!

bridgekeeper bot commented May 28, 2025

Uh oh!

openjdk bot commented May 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openjdk bot commented May 28, 2025

Uh oh!

teshull commented May 28, 2025

Uh oh!

bridgekeeper bot commented May 28, 2025

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

teshull May 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

teshull May 29, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

dougxc May 29, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

dougxc commented May 30, 2025

Uh oh!

mlbridge bot commented May 30, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Webrevs

Uh oh!

dougxc left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

dougxc left a comment

Choose a reason for hiding this comment

Uh oh!

tkrodriguez left a comment

Choose a reason for hiding this comment

Uh oh!

teshull commented Jun 3, 2025

Uh oh!

openjdk bot commented Jun 3, 2025

Uh oh!

dougxc commented Jun 3, 2025

Uh oh!

openjdk bot commented Jun 3, 2025

Uh oh!

teshull commented May 28, 2025 •

edited by openjdk bot

Loading

openjdk bot commented May 28, 2025 •

edited

Loading

teshull May 28, 2025 •

edited

Loading

teshull May 29, 2025 •

edited

Loading

dougxc May 29, 2025 •

edited

Loading

mlbridge bot commented May 30, 2025 •

edited

Loading