-
Notifications
You must be signed in to change notification settings - Fork 26
Fixed backing out a backport #160
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
👋 Welcome back jwilhelm! A progress list of the required criteria for merging this PR into |
@JesperIRL This change now passes all automated pre-integration checks. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been no new commits pushed to the ➡️ To integrate this PR with the above commit message to the |
Webrevs
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You have the direction of the causes / caused-by links reversed.
/integrate |
Going to push as commit 29245b3. |
@JesperIRL Pushed as commit 29245b3. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
Backing out a change was updated to not use sub-tasks, but the similar case of backing out a backport was missed.
Progress
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/guide.git pull/160/head:pull/160
$ git checkout pull/160
Update a local copy of the PR:
$ git checkout pull/160
$ git pull https://git.openjdk.org/guide.git pull/160/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 160
View PR using the GUI difftool:
$ git pr show -t 160
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/guide/pull/160.diff
Using Webrev
Link to Webrev Comment