Expose HTTP response headers in NSError
for non-2xx responses
#936
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
When a token request returns a non-2xx HTTP status (for example 400), AppAuth currently exposes only the response body and status code in the resulting
NSError
.There is no way for SDK users to access the response headers, which are required in some flows.
Solution
Include
HTTPURLResponse.allHeaderFields
in theNSError.userInfo
for non-2xx responses under a new exported key:This change is minimal and fully backward compatible. Successful responses are not affected.
Background
DPoP (RFC 9449 §8) specifies a case where an authorization server responds to a token request with a 400 status and includes a
DPoP-Nonce
header. Clients must extract this nonce and retry the request with a re-signed proof.Without access to the response headers, it is impossible to implement a compliant DPoP flow using AppAuth.