battlefield protocol sometimes missing fields and result in unpacking too many values #18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…cking too many values
Contributor
Author
|
Hi @BattlefieldDuck - is there any possibility to include it? Currently a project of mine relies on this to query bfbc2 server correctly. |
Member
|
thanks @derkalle4 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
thank you very much for your library. I use it on a small project and found an error: some bfbc2 servers do not have enough values to unpack and therefore your library crashes. The following fix does work work fine for me. Feel free to suggest changes if necessary.
Thanks for this great library! Helping me a lot :)