Fix discord user schema

[scottanderson]

Description:

Update the discord user zod schema to address login failures for users without avatars.

Please complete the following:

• I have added screenshots for all UI updates
• I process any text displayed to the user through translateText() and I've added it to the en.json file
• I have added relevant tests to the test directory
• I confirm I have thoroughly tested these changes and take full responsibility for any bugs introduced
• I understand that submitting code with bugs that could have been caught through manual testing blocks releases and new features for all contributors

[coderabbitai]

Walkthrough

The schema for the UserMeResponse object was updated to make the avatar and global_name fields nullable and the locale field optional. This change allows these fields to be set to null or omitted, relaxing previous validation rules.

Changes

File	Change Summary
src/core/ApiSchemas.ts	Made avatar and global_name nullable and locale optional in schema.

Poem

Fields once strict, now gently bend,
Nulls and options, rules transcend.
Avatars may fade away,
Locales may choose not to stay.
In schemas' dance, we find our way—
TypeScript smiles, and leads the play!
😊📝

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 ESLint

If the error stems from missing dependencies, add them to the package.json file. For unrecoverable errors (e.g., due to private dependencies), disable the tool in the CodeRabbit configuration.

npm error Exit handler never called!
npm error This is an error with npm itself. Please report this error at:
npm error https://github.com/npm/cli/issues
npm error A complete log of this run can be found in: /.npm/_logs/2025-05-31T11_11_44_374Z-debug-0.log

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 5c750f1 and eeb1e1a.

📒 Files selected for processing (1)

• src/core/ApiSchemas.ts (1 hunks)

🔇 Additional comments (4)

src/core/ApiSchemas.ts (4)

37-37: Good fix for avatar field!

Making the avatar field nullable solves the login issue for users without avatars. This matches Discord's API where avatar can be null.

---

39-39: Consistent with Discord API behavior.

The global_name field can indeed be null in Discord's API, so this change is correct and follows the same pattern as the avatar fix.

---

41-41:

❓ Verification inconclusive

Verify downstream code handles optional locale.

Making locale optional is good, but ensure that code using this schema properly handles when locale is undefined.

---

🏁 Script executed:

#!/bin/bash
# Search for code that accesses the locale field to ensure it handles undefined values
rg -A 3 -B 1 "\.locale\b" --type ts

Length of output: 37

---

🏁 Script executed:

#!/bin/bash
# Search across all files for .locale property access (including optional chaining) or bracket notation
rg "\.locale\??\b|\['locale'\]" -A3 -B1

Length of output: 47

---

Manual check: ensure downstream code handles optional locale

I couldn’t find any direct uses of .locale in the repo. Please review any code that consumes this schema and confirm it safely handles locale being undefined—for example:

• Places where you read or destructure data.locale
• Calls that pass locale into formatting or lookup functions
• Any defaulting logic when locale isn’t provided

---

34-47:

✅ Verification successful

Clean TypeScript schema changes.

The changes use proper Zod patterns with .nullable() and .optional(). This is clean, readable TypeScript that follows best practices.

---

🏁 Script executed:

#!/bin/bash
# Check for any code that assumes avatar or global_name are always strings
rg -A 2 -B 1 "(avatar|global_name)" --type ts | grep -v "nullable\|null\|undefined\|\?"

Length of output: 293

---

🏁 Script executed:

#!/bin/bash
# List all occurrences of avatar and global_name usage across TypeScript files
rg -n "(avatar|global_name)" --type ts

Length of output: 167

---

✅ Approved: Zod schema updates use .nullable() and .optional() correctly and no downstream code depends on avatar or global_name as non-null strings

• Searched all .ts files for avatar and global_name; only occurrences are in the schema itself.
• No code assumes these fields are always present or non-null.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Explain this complex logic.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai explain this code block.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and explain its main purpose.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.