Skip to content

Conversation

@dimitre
Copy link
Member

@dimitre dimitre commented Apr 12, 2023

This is a fix of local_addons functionality
translates some ofDirectory operations and listings to fs::path, so it removes the complexity of using ofToDataPath
because projectGenerator/bin/data is not used.

with this PR we can remove "local_addons" folder from the project itself, it will be created from PG

@dimitre dimitre marked this pull request as ready for review April 12, 2023 13:36
@ofTheo
Copy link
Member

ofTheo commented Apr 12, 2023

one thing to look at is the non Xcode projects/files that reference ofxProjectGenerator:
https://github.com/openframeworks/projectGenerator/search?q=ofxProjectGenerator

Ideally this PR would also update those files so they continue to be able to compile the PG.

@dimitre
Copy link
Member Author

dimitre commented Apr 12, 2023

Nice I'll be updating this PR.
btw I think this does the trick to the optional folder

		mv apps/projectGenerator/commandLine .
		if [ -d "apps/projectGenerator/ofxProjectGenerator" ]; then
			mv apps/projectGenerator/ofxProjectGenerator .
		fi
		rm -rf apps/projectGenerator
		mkdir apps/projectGenerator
		mv commandLine apps/projectGenerator/
		if [ -d "ofxProjectGenerator" ]; then
			mv ofxProjectGenerator apps/projectGenerator/
		fi
		cd apps/projectGenerator/commandLine
		deleteCodeblocks
		deleteVS
		deleteXcode

@ofTheo
Copy link
Member

ofTheo commented Apr 12, 2023

ahh thanks - already did it via:
openframeworks/openFrameworks@a76ef83

slightly different approach - but should work

@dimitre
Copy link
Member Author

dimitre commented Apr 12, 2023

I'm also removing Poco manually from everything. :) 🧹

@dimitre
Copy link
Member Author

dimitre commented Apr 12, 2023

Finally, cleanup done and passing tests.
I just don't have how to test if the project files edits are ok

@ofTheo ofTheo merged commit 0949940 into openframeworks:master Apr 12, 2023
@dimitre dimitre deleted the lean2 branch April 12, 2023 20:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants