Light polish for the animation chapter #270
Conversation
chapters/animation/chapter.md
Outdated
| When I say continuous function, what I mean is if you pass in smaller changes as input, you get smaller output and if you pass in the same value you get the same result. For example, `sin(1.7)` always returns the same value, and `ofNoise(1.7)` also always returns the same result. Likewise if you call `sin(1.7)` and `sin(1.75)` you get results that are continuous (meaning, you can call `sin(1.71) sin(1.72)... sin(1.74)` to get intermediate results). | ||
|
|
||
| You can do the same thing with ofNoise -- here, I write a for loop to draw noise as a line. `ofNoise` takes an input, here i/10 and produces an output which is between 0 and 1. [`ofSignedNoise`](http://openframeworks.cc/documentation/math/ofMath.html#!show_ofSignedNoise "ofSignedNoise Documentation Page") is similar but it produces an output between -1 and 1. | ||
| You can do the same thing with ofNoise -- here, I write a for loop to draw noise as a line. `ofNoise` takes an input -- here, i/10 -- and produces an output which is between 0 and 1. [`ofSignedNoise`](http://openframeworks.cc/documentation/math/ofMath.html#!show_ofSignedNoise "ofSignedNoise Documentation Page") is similar but it produces an output between -1 and 1. |
There was a problem hiding this comment.
This reads a little awkwardly to me. What about:
You can do the same thing with ofNoise. Here, I write a for loop to draw noise as a line.
ofNoisetakes an input (i/10 in this case) and produces an output which is between 0 and 1.
There was a problem hiding this comment.
You dashed my em dash dreams, @mikewesthad. But I like that that, too. Just updated and rebased.
|
This looks great to me - thanks again @BrianSipple for the edits. There was one edit where I had an additional suggestion. (Pinging the author, @ofZach, to let him know about the PR.) |
BrianSipple
force-pushed
the
animation-2
branch
from
3c73f55 to
22d2a37
Compare
|
This looks good to me, so I'm going to go ahead and merge it in. @ofZach can reopen/revert if needed. Thanks for the PR. |
|
hey sorry but I'd really like to review changes to my chapter |
|
@ofZach - no problem, reverted. Sorry! Just trying to make sure we don't accumulate stale issues & PRs when the scope of the changes is small. |
|
thanks -- I was traveling and didn't have a chance to look at this... I wouldn't change for loop to for-loop (which seems wrong to me) but besides that it seems ok to me and they are small changes. thanks for giving me a chance to check this out. |
|
also, thanks @BrianSipple for fixes! |
|
@mikewesthad It looks like reverting the changes doesn't also reopen the PR. I'll open a new one for @ofZach to get some 👀 on (while also addressing the feedback). |
|
@BrianSipple - sorry about that! Thanks for opening a new one |
3 participants
I made a few polishes for the animation chapter as I went through it.
Outside of my editor deleting a few extra spaces in some places, one change is a terminology fix and the other is a punctuation fix.
Cheers!