Workaround for #33 - go sub-modules #34
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexellis
force-pushed
the
openfaasltd/sub-modules
branch
from
bebfc6f to
b42517f
Compare
Fixes: #33 Go sub-modules do not work with this template, because the of limitations on how local imports and the "replace" word works in Go modules. You can only use "replace" in the root-level module i.e. "main.go" https://github.com/golang/go/wiki/Modules#gomod This patch was tested with the following repo: [email protected]:alexellis/golang-middleware-relative-import.git * Documentation in the README has been updated * Tested e2e and with a local "go test" in GOPATH with modules turned on and Go 1.13 * Updated copy commands in Dockerfile so that they use a faster mechanism, vs creating a new container step to chown (must be tested with buildkit before merging, since buildkit did not like this approach in the past when running as a restricted user at runtime) Signed-off-by: Alex Ellis (OpenFaaS Ltd) <[email protected]>
alexellis
force-pushed
the
openfaasltd/sub-modules
branch
from
b42517f to
62fa9ba
Compare
Waterdrips
reviewed
Jan 24, 2020
Signed-off-by: Alex Ellis (OpenFaaS Ltd) <[email protected]>
Signed-off-by: Alex Ellis (OpenFaaS Ltd) <[email protected]>
|
Lgtm from Lucas on Slack. We'll treat this as experimental, unsupported for the time being and gauge interest |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Workaround for #33 - go sub-modules
Fixes: #33
Go sub-modules do not work with this template, because the of
limitations on how local imports and the "replace" word works
in Go modules. You can only use "replace" in the root-level module
i.e. "main.go"
https://github.com/golang/go/wiki/Modules#gomod
This patch was tested with the following repo:
[email protected]:alexellis/golang-middleware-relative-import.git
Signed-off-by: Alex Ellis (OpenFaaS Ltd) [email protected]