Skip to content

Conversation

@martindekov
Copy link
Contributor

Add to cli field in file build.md explanation to what the --tag
feature does.

Signed-off-by: Martin Dekov (VMware) [email protected]

Add to cli field in file build.md explanation to what the --tag
feature does.

Signed-off-by: Martin Dekov (VMware) <[email protected]>
@martindekov martindekov force-pushed the mrtind/49_document_tag_feature branch from 8cddad6 to d61ec1e Compare July 25, 2018 08:18
@martindekov
Copy link
Contributor Author

This PR references issue #49.

@alexellis
Copy link
Member

The outline looks good, but the ask was for this to be covered for all the sub-commands (push,build,deploy) in some generic way. Do you think it deserves its own sub-page?

@alexellis
Copy link
Member

Referring to #49:

Remember this covers build/push and deploy - do we really want to duplicate the text in each part - or could it be a sub-page of the CLI heading?

alexellis added a commit that referenced this pull request Jul 25, 2018
- --tag was added to the CLI for build/push/deploy, this change
takes inspiration from #50 via @MrTinD and closes #49.

Signed-off-by: Alex Ellis (VMware) <[email protected]>
@alexellis alexellis closed this Jul 25, 2018
@alexellis
Copy link
Member

I've written this up in a dedicated page, but we may want to make some small references in each page or section on build/deploy/push back to the tagging feature.

ericstoekl pushed a commit to ericstoekl/docs that referenced this pull request Jul 25, 2018
- --tag was added to the CLI for build/push/deploy, this change
takes inspiration from openfaas#50 via @MrTinD and closes openfaas#49.

Signed-off-by: Alex Ellis (VMware) <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants