EIP-86 #4697

arkpar · 2017-02-27T21:19:13Z

debris · 2017-03-09T13:55:55Z

ethcore/src/engines/instant_seal.rs

-	fn schedule(&self, _env_info: &EnvInfo) -> Schedule {
-		Schedule::new_post_eip150(usize::max_value(), true, true, true)
+	fn schedule(&self, block_number: BlockNumber) -> Schedule {
+		let eip86 = block_number >= self.params.eip98_transition;


typo 86 != 98

debris · 2017-03-09T14:00:22Z

ethcore/src/spec/spec.rs

 			min_gas_limit: p.min_gas_limit.into(),
 			fork_block: if let (Some(n), Some(h)) = (p.fork_block, p.fork_hash) { Some((n.into(), h.into())) } else { None },
 			eip98_transition: p.eip98_transition.map_or(0, Into::into),
+			eip86_transition: p.eip86_transition.map_or(0, Into::into),


maybe it should be u64::max_value() instead of 0 until we release?

Makes sense to enable this when other metropolis changes are ready.

debris · 2017-03-09T14:06:39Z

ethcore/src/engines/authority_round.rs

-	fn schedule(&self, _env_info: &EnvInfo) -> Schedule {
-		Schedule::new_post_eip150(usize::max_value(), true, true, true)
+	fn schedule(&self, block_number: BlockNumber) -> Schedule {
+		let eip86 = block_number >= self.params.eip98_transition;


also a typo

debris · 2017-03-09T14:17:47Z

ethcore/src/ethereum/ethash.rs

+				block_number >= self.ethash_params.eip160_transition,
+				block_number >= self.ethash_params.eip161abc_transition,
+				block_number >= self.ethash_params.eip161d_transition,
+				block_number >= self.params.eip98_transition


debris · 2017-03-10T10:16:56Z

ethcore/src/engines/tendermint/mod.rs

-	fn schedule(&self, _env_info: &EnvInfo) -> Schedule {
-		Schedule::new_post_eip150(usize::max_value(), true, true, true)
+	fn schedule(&self, block_number: BlockNumber) -> Schedule {
+		let eip86 = block_number >= self.params.eip98_transition;


one more :)

ugh, I'm going to replace it with Schedule::from_params for DRY after #4757 is merged. https://github.com/ethcore/parity/pull/4757/files#diff-ef2687136b4e032043a492e9e53dcb7cR177

gavofyork · 2017-03-30T18:19:03Z

what's the rationale behind EnvInfo -> BlockNumber change?

arkpar · 2017-03-31T13:25:39Z

There's a number of places now where Schedule is created from the block number. Creating a fake EnvInfo struct seems wasteful.

arkpar · 2017-03-31T14:39:13Z

Updated with recent EIP changes. gasprice, noce, value are now required to be zero for unsigned transactions.

gavofyork · 2017-04-12T14:00:25Z

ethcore/src/engines/authority_round.rs


-	fn schedule(&self, _env_info: &EnvInfo) -> Schedule {
-		Schedule::new_post_eip150(usize::max_value(), true, true, true)
+	fn schedule(&self, block_number: BlockNumber) -> Schedule {


why &EnvInfo -> BlockNumber?

There's a number of places where Schedule is created from the block number number. This PR introduces quite a few more. Creating a fake EnvInfo struct seems wasteful. And furthermore since all of the data except for the block number is unreliable it may introduce subtle bugs if any future implementation will have to rely on any other field.

gavofyork · 2017-04-12T14:10:15Z

ethcore/src/executive.rs

+			From::from(stream.as_raw().sha3())
+		},
+		CreateContractAddress::FromCodeHash => {
+			let mut buffer = [0xffu8; 20 + 32];


YP & EIP state that this should be the null sender (i.e. zero address). am i missing something?

I think the fix is wrong (and I was mistaken in a PR to YP).

The relevant EIP says the pad is 0xffff..ff. The NULL_SENDER is defined to be 0xffff..ff.

gavofyork · 2017-04-12T14:11:33Z

ethcore/src/executive.rs

 	) -> evm::Result<U256> where T: Tracer, V: VMTracer {
+
+		// TODO: enable this check once consensus tests are fixed.
+		//if !overwrite_existing && self.state.exists(&params.address) {


should be enabled?

enabled now

gavofyork · 2017-04-12T14:12:13Z

ethcore/src/executive.rs

 		tracer: &mut T,
-		vm_tracer: &mut V
+		vm_tracer: &mut V,
+		_overwrite_existing: bool


overwrite existing what?

removed that param since it is already in the schedule.

gavofyork · 2017-04-12T14:19:35Z

rpc/src/v1/impls/light/parity.rs

 			txq.ready_transactions(chain_info.best_block_number, chain_info.best_block_timestamp)
 				.into_iter()
-				.map(Into::into)
+				.map(|tx| Transaction::from_pending(tx, chain_info.best_block_number, u64::max_value())) //TODO: enable EIP-86


gavofyork · 2017-04-12T14:19:40Z

rpc/src/v1/impls/light/parity.rs

 			txq.future_transactions(chain_info.best_block_number, chain_info.best_block_timestamp)
 				.into_iter()
-				.map(Into::into)
+				.map(|tx| Transaction::from_pending(tx, chain_info.best_block_number, u64::max_value())) //TODO: enable EIP-86


gavofyork · 2017-04-12T14:22:18Z

one probable correction needed and a few clarifications.

gavofyork · 2017-04-18T12:19:42Z

needs resolving.

arkpar added A0-pleasereview 🤓 Pull request needs code review. A1-onice 🌨 Pull request is reviewed well, but should not yet be merged. M4-core ⛓ Core client code / Rust. labels Feb 27, 2017

pirapira mentioned this pull request Mar 1, 2017

Abstraction of transaction origin and signature.md ethereum/EIPs#208

Merged

arkpar removed the A1-onice 🌨 Pull request is reviewed well, but should not yet be merged. label Mar 7, 2017

arkpar mentioned this pull request Mar 9, 2017

Byzantium release #4833

Closed

12 tasks

debris reviewed Mar 9, 2017

View reviewed changes

debris added A4-gotissues 💥 Pull request is reviewed and has significant issues which must be addressed. and removed A0-pleasereview 🤓 Pull request needs code review. labels Mar 9, 2017

debris reviewed Mar 9, 2017

View reviewed changes

arkpar force-pushed the eip86 branch from 027b044 to 903889a Compare March 9, 2017 16:20

arkpar added A0-pleasereview 🤓 Pull request needs code review. and removed A4-gotissues 💥 Pull request is reviewed and has significant issues which must be addressed. labels Mar 9, 2017

debris reviewed Mar 10, 2017

View reviewed changes

debris mentioned this pull request Mar 10, 2017

EIP-116 (214), #4833 #4851

Merged

arkpar force-pushed the eip86 branch from 903889a to 978327e Compare March 10, 2017 14:38

arkpar added A3-inprogress ⏳ Pull request is in progress. No review needed at this stage. and removed A0-pleasereview 🤓 Pull request needs code review. labels Mar 12, 2017

arkpar force-pushed the eip86 branch from 978327e to f492b79 Compare March 15, 2017 14:13

arkpar added A0-pleasereview 🤓 Pull request needs code review. and removed A3-inprogress ⏳ Pull request is in progress. No review needed at this stage. labels Mar 15, 2017

arkpar force-pushed the eip86 branch from f492b79 to a38d8b7 Compare March 31, 2017 14:36

arkpar force-pushed the eip86 branch 2 times, most recently from 195dbeb to ea479a0 Compare April 5, 2017 13:36

gavofyork reviewed Apr 12, 2017

View reviewed changes

gavofyork added A4-gotissues 💥 Pull request is reviewed and has significant issues which must be addressed. and removed A0-pleasereview 🤓 Pull request needs code review. labels Apr 12, 2017

arkpar force-pushed the eip86 branch from ea479a0 to 52d6bcd Compare April 13, 2017 17:48

arkpar added A0-pleasereview 🤓 Pull request needs code review. and removed A4-gotissues 💥 Pull request is reviewed and has significant issues which must be addressed. labels Apr 13, 2017

gavofyork added A7-looksgoodcantmerge 🙄 Pull request is reviewed well, but cannot be merged due to conflicts. and removed A0-pleasereview 🤓 Pull request needs code review. labels Apr 18, 2017

EIP-86

68966a8

arkpar force-pushed the eip86 branch from 52d6bcd to 68966a8 Compare April 18, 2017 13:35

arkpar added A0-pleasereview 🤓 Pull request needs code review. and removed A7-looksgoodcantmerge 🙄 Pull request is reviewed well, but cannot be merged due to conflicts. labels Apr 18, 2017

Disable EIP-86 auto activation for now

c2ab130

NikVolf added A8-looksgood 🦄 Pull request is reviewed well. and removed A0-pleasereview 🤓 Pull request needs code review. labels Apr 19, 2017

arkpar merged commit b50fb71 into master Apr 19, 2017

arkpar deleted the eip86 branch April 19, 2017 12:30

arkpar mentioned this pull request Apr 19, 2017

Correct contract address for EIP-86 #5473

Merged

Uh oh!

EIP-86 #4697

EIP-86 #4697

Uh oh!

Conversation

arkpar commented Feb 27, 2017

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

gavofyork commented Mar 30, 2017

Uh oh!

arkpar commented Mar 31, 2017

Uh oh!

arkpar commented Mar 31, 2017

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

pirapira Apr 18, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

gavofyork commented Apr 12, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

gavofyork commented Apr 18, 2017

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

pirapira Apr 18, 2017 •

edited

Loading

gavofyork commented Apr 12, 2017 •

edited

Loading