fix: Convert UUIDField columns to uuid type for MariaDB #37494
Conversation
openedx-webhooks
added
the
open-source-contribution
|
Thanks for the pull request, @blarghmatey! This repository is currently maintained by Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review. 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. DetailsWhere can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources: When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
The behavior of the MariaDB backend has changed behavior for UUIDField from a `CharField(32)` to an actual `uuid` type. This is not converted automatically, which results in all writes to the affected columns to error with a message about the data being too long. This is because the actual tring being written is a UUID with the `-` included, resulting in a 36 character value which can't be inserted into a 32 character column.
blarghmatey
force-pushed
the
mariadb_uuid_field_conversion
branch
from
fce4503 to
0515e64
Compare
|
Ugh, I hadn't realized that Django was doing this for MariaDB. 😞 Are you planning to make PRs for other repos as well, like https://github.com/openedx/openedx-learning and https://github.com/openedx/edx-submissions? Thank you. |
|
@blarghmatey: I assigned myself as a reviewer for this one. I'll look at it in the next day or so. |
ormsbee
left a comment
ormsbee
left a comment
There was a problem hiding this comment.
I'll merge as soon as tests pass (I'm assuming the testing issue I saw was transient).
|
Thanks! I'm also working on identifying other repos that need a similar set of migrations and opening PRs for them. |
|
@blarghmatey: Please feel free to tag me on all these MariaDB PRs. Thank you! |
The behavior of the MariaDB backend has changed behavior for UUIDField from a `CharField(32)` to an actual `uuid` type. This is not converted automatically, which results in all writes to the affected columns to error with a message about the data being too long. This is because the actual tring being written is a UUID with the `-` included, resulting in a 36 character value which can't be inserted into a 32 character column. (cherry picked from commit 0fdb6ed)
The behavior of the MariaDB backend has changed behavior for UUIDField from a `CharField(32)` to an actual `uuid` type. This is not converted automatically, which results in all writes to the affected columns to error with a message about the data being too long. This is because the actual tring being written is a UUID with the `-` included, resulting in a 36 character value which can't be inserted into a 32 character column.
The behavior of the MariaDB backend has changed behavior for UUIDField from a `CharField(32)` to an actual `uuid` type. This is not converted automatically, which results in all writes to the affected columns to error with a message about the data being too long. This is because the actual tring being written is a UUID with the `-` included, resulting in a 36 character value which can't be inserted into a 32 character column.
3 participants
Description
The behavior of the MariaDB backend has changed behavior for UUIDField from a
CharField(32)to an actualuuidtype. This is not converted automatically, which results in all writes to the affected columns to error with a message about the data being too long. This is because the actual tring being written is a UUID with the-included, resulting in a 36 character value which can't be inserted into a 32 character column.Supporting information
https://docs.djangoproject.com/en/5.2/releases/5.0/#migrating-uuidfield
Testing instructions
Configure edx-platform to use a MariaDB database, run the migrations up through the Django 5.2 update, then perform the 5.2 update and try to enroll a user. It will error. After applying these migrations it should work.
Deadline
This is a blocking error that prevents the master branch from being operational when using MariaDB as the database engine.