Skip to content

Conversation

@atheo89
Copy link
Member

@atheo89 atheo89 commented Sep 1, 2023

Fix for #98

NOTE: This PR copies the main implementation from this one: #111

This PR includes the following changes:

  1. PyTorch is now being installed from the Torch repository instead of PyPI.

  2. Package updates:

    • torch = "~=1.13.1" to torch = "~=2.0.0"
    • torchvision = "~=0.14.1" to torchvision = "~=0.15.1"
  3. The parent image has been changed, it is now derived from the cuda-data-science notebook.

  4. Updated the piplock files

How Has This Been Tested?

PyTorch Installation via Torch repocitory:
image

Spin up the new PyTorch notebook:
image

Merge criteria:

Note: Should be merged first the CI PR: openshift/release#40199

  • The commits are squashed in a cohesive manner and have meaningful messages.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work

Description

How Has This Been Tested?

Merge criteria:

  • The commits are squashed in a cohesive manner and have meaningful messages.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 1, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from atheo89. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@atheo89 atheo89 changed the title Update PyTorch notebook [2023b] Update PyTorch notebook Sep 1, 2023
@atheo89
Copy link
Member Author

atheo89 commented Sep 8, 2023

Closing this PR as it will be addressed as part of the upcoming notebooks upgrade.
#205

@atheo89 atheo89 closed this Sep 8, 2023
harshad16 added a commit to harshad16/odh-notebooks that referenced this pull request Apr 4, 2024
@atheo89 atheo89 deleted the upd-pytorch-2023b branch October 23, 2024 08:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant