Skip to content

Conversation

@Kumataro
Copy link
Contributor

@Kumataro Kumataro commented May 1, 2024

Close #3732
Related opencv/opencv#23329

Pull Request Readiness Checklist

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

  • I agree to contribute to the project under Apache 2 License.
  • To the best of my knowledge, the proposed patch is not based on a code under GPL or another license that is incompatible with OpenCV
  • The PR is proposed to the proper branch
  • There is a reference to the original bug report and related work
  • There is accuracy test, performance test and test data in opencv_extra repository, if applicable
    Patch to opencv_extra has the same branch name.
  • The feature is well documented and sample code can be built with the project CMake

@Kumataro
Copy link
Contributor Author

Kumataro commented May 1, 2024

One ideal is to modify the source code so that the build will pass. However, the issues blocking this build did not surface 1 year after opencv/opencv#23329 .

Therefore, I think it is appropriate to disable this sample code.

@asmorkalov
Copy link
Contributor

@AleksandrPanov could you handle this? The sample update should be relatively easy.

@Kumataro
Copy link
Contributor Author

Kumataro commented May 3, 2024

Thank you for your comment !

The sample update should be relatively easy.

Updating this sample program suitabled for OpenCV4.x is better than this pull request.

I investigated this problem at 2023/5, so perhaps this result may be incorrect in after OpenCV 4.9.0.

opencv/opencv#23329 (comment)

aruco module is moved between opencv and opencv_contrib in OpenCV 4.7.0 URL.
In this time, some functions had been deprecated,, and some functions lost backcompatibility.

And I had created temporary patch to build it, but I couldn't test it (I had/have no camera to test it). I hope this information is of some help.

@opencv-alalek
Copy link

replaced by #3735

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ovis: example: aruco_ar_demo.cpp references out-dated header.

3 participants