Skip to content

Comments around environment and user values #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Comments around environment and user values #2

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 6 additions & 5 deletions runtime.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -320,7 +320,10 @@ See links for details about mountvol in Windows.
"processes": [
{
"tty": true,
"user": "daemon",
"user": {
"name": "daemon",
"id": 0,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this should be a string so it can be "optional"

},
"args": [
"sh"
],
Expand All @@ -338,11 +341,9 @@ The processes to be created inside the container are specified in a processes ar
```
The command to start a process is specified in an array of args. It will be run in the working directory specified in the string cwd.

Environment variables are specified is an array called env.
Environment variables are specified is an array called `env`. Elements in the array are specified as `strings` in the form "KEY=value", and are passed unmodified to the underlying process.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is an -> in an


Elements in the array are specified as Strings in the form "KEY=value"

The user inside the container under which the process is running is specified under the user key.
The user inside the container under which the process is running is specified under the `user` object. The `user` object may specify a `name` which is the string value of the user name, or the `id` which is an integer representing the Unix user identifier of the user. This is the expected value of the user as seen from the inside of the container - the runtime may define a mapping between the value seen inside the container and the value the host operating system sees.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what if both are supplied?


tty is a boolean that lets you specify whether you want a terminal attached to that process. tty cannot be set to true for more than one process in the array, else oc returns the error code THERE_CAN_BE_ONLY_ONE_TTY.

Expand Down