Comments around environment and user values

[smarterclayton]

Clarify environment more strictly, and propose changes to user to separate "id" and "name" as distinct entities. I think it is important to separate uid and name explicitly, given that the uid can be known outside the container, but the name may only have meaning inside the container (in the case of Linux containers that have custom /etc/nsswitch.conf)

Signed-off-by: Clayton Coleman [email protected]

[philips]

I agree with this change. We need to be explicit about the difference between id and name.

[smarterclayton]

Brandon, is the defaulting behavior of the process ownership pid something you would like to see as well (uid of run command is the implicit default uid?)

On Jun 23, 2015, at 5:57 PM, Brandon Philips [email protected] wrote:

I agree with this change. We need to be explicit about the difference between id and name.

—
Reply to this email directly or view it on GitHub.

[philips]

@smarterclayton Not sure I follow. Can you give an example?

[smarterclayton]

If uid or name are unspecified, use the owning uid of the identified "exec" process file as the default uid. Adds one more level of indirection in order to resolve the start, but avoids defaulting to "0" in many cases. Not a huge issue to me, but it's not unusual for the exec process file owner to mean something.

On Jun 23, 2015, at 6:25 PM, Brandon Philips [email protected] wrote:

@smarterclayton Not sure I follow. Can you give an example?

—
Reply to this email directly or view it on GitHub.

[philips]

@smarterclayton I guess it depends on if this behavior works under Windows. If not it feels like it is better to be require explicitness.

[mrunalp]

Yes, I agree that the defaulting depends on the OS behavior. On linux, unprivileged containers are possible only using a relatively newer kernel with user namespaces enabled. Hence, in most cases the container is started as root and a default of root/0 makes sense.

[philips]

this should be a string so it can be "optional"

[crosbymichael]

@smarterclayton I'm going to close this one because we have the same discussion going on in #10 about the user uid/gid vs username.

There is nothing wrong with the PR, I just want to keep the discussion in one place and your PR lost the coin flip, sorry ;)

[smarterclayton]

I'll survive :). Will split the env changes out

On Jun 29, 2015, at 4:48 PM, Michael Crosby [email protected]
wrote:

@smarterclayton https://github.com/smarterclayton I'm going to close this
one because we have the same discussion going on in #10
#10 about the user uid/gid
vs username.

There is nothing wrong with the PR, I just want to keep the discussion in
one place and your PR lost the coin flip, sorry ;)

—
Reply to this email directly or view it on GitHub
#2 (comment).