Reopen cgroupRootHandle if it was unexpectedly opened to another file #42
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sctb512
force-pushed
the
reopen-cgroupFd
branch
2 times, most recently
from
4689520 to
4650a9e
Compare
sctb512
changed the title
Signed-off-by: Bin Tang <[email protected]>
sctb512
force-pushed
the
reopen-cgroupFd
branch
from
4650a9e to
243957d
Compare
|
Thank you for your PR. It would be greatly appreciated if you could provide some failure logs and help us analyze the root cause of this issue. For instance, could it be related to the Go stdlib’s file descriptor shuffling bug (issue opencontainers/runc#4452)? I believe it's worth investing time to identify the underlying cause. Reopening the cgroup root file descriptor should be considered a last resort. |
|
@sctb512 can you reply to the comment above? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Try to address opencontainers/runc#3026