Skip to content
This repository was archived by the owner on Sep 28, 2023. It is now read-only.

Add Relative Position encoding #6

Closed
wants to merge 7 commits into from

Conversation

jacobbieker
Copy link
Member

Pull Request

Description

This is the relative position encoding from #4 as it was getting a bit complicated, and the absolute position encoding is a lot simpler to have implemented.

Fixes #

How Has This Been Tested?

Unit tests

  • No
  • Yes

Checklist:

  • My code follows OCF's coding style guidelines
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked my code and corrected any misspellings

@jacobbieker jacobbieker added the enhancement New feature or request label Oct 13, 2021
@jacobbieker jacobbieker self-assigned this Oct 13, 2021
@jacobbieker
Copy link
Member Author

After talking over it with @JackKelly closing this for now. Absolute position encoding does give the relative positions in time and space for different inputs, and is simpler. The only benefit this encoding seems to have is that the inputs would stretch from -1 to 1, versus in the absolute encoding, they tend to be a much smaller range.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant