Skip to content
This repository was archived by the owner on Sep 11, 2023. It is now read-only.

Conversation

@JackKelly
Copy link
Contributor

@JackKelly JackKelly commented Nov 18, 2021

Pull Request

Description

Fixes #325

How Has This Been Tested?

  • No
  • Yes, unit tests run
  • Yes, prepare_ml_data.py runs

Checklist:

  • My code follows OCF's coding style guidelines
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked my code and corrected any misspellings

@JackKelly JackKelly added enhancement New feature or request refactoring labels Nov 18, 2021
@JackKelly JackKelly self-assigned this Nov 18, 2021
future = executor.submit(
data_source.create_batches,
# Key word arguments to be passed into data_source.create_batches():
kwargs_for_create_batches = dict(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thats how you do it! nice

@JackKelly JackKelly merged commit 5499861 into main Nov 18, 2021
@JackKelly JackKelly deleted the jack/325-use-multiprocessing-pool-in-manager branch November 18, 2021 15:04
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

enhancement New feature or request refactoring

Projects

None yet

Development

Successfully merging this pull request may close these issues.

In Manager use multiprocessing.Pool not ProcessPoolExecutor

3 participants