This repository was archived by the owner on Sep 11, 2023. It is now read-only.
Issue/202 modality files #216
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # nowcasting_dataset/cloud/local.py
JackKelly
approved these changes
Oct 11, 2021
|
|
||
| # make folder | ||
| folder = os.path.join(path, name) | ||
| make_folder(path=folder) |
There was a problem hiding this comment.
How much time does make_folder take to run if folder already exists? (I ask because save_netcdf() will be called tens of thousands of times in one run of prepare_ml_data.py!)
There was a problem hiding this comment.
perhaps this should just happen on the first batch, i.e 'batch_idx ==0 '. Althought I dont think this will take very long
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
Description
Fixes #202
How Has This Been Tested?
Save netcdf files for batch in seperate folders
Checklist: