This repository was archived by the owner on Sep 11, 2023. It is now read-only.
add method to split by random day for train and test, and by year for… #207
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
JackKelly
approved these changes
Oct 7, 2021
| validation_test_datetime_split: pd.Timestamp, | ||
| ) -> (List[pd.Timestamp], List[pd.Timestamp], List[pd.Timestamp]): | ||
| """ | ||
| Split datetimes into train, validation and test by two specific datetime splits |
There was a problem hiding this comment.
Please mention that the train_validation_datetime_split must come before the validation_test_datetime_split
7 tasks
7 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add split method for random day, and year for test set
Pull Request
Description
add method to split by
Note: Have not changed default method to this, and we may not have the data yet for this
Fixes #
How Has This Been Tested?
Added a unittest
Checklist: