Skip to content
This repository was archived by the owner on Sep 11, 2023. It is now read-only.

Conversation

peterdudfield
Copy link
Contributor

@peterdudfield peterdudfield commented Oct 6, 2021

Pull Request

Description

Method to open topo data from gcs.
Due to limitation of 'rioxarray' the file must be downloaded locally and then loaded

Fixes #197

How Has This Been Tested?

Added unit test, which has been skipped as not access to GCS for CI

  • No
  • Yes

Checklist:

  • My code follows OCF's coding style guidelines
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked my code and corrected any misspellings

Copy link
Contributor

@jacobbieker jacobbieker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks!

@peterdudfield peterdudfield merged commit b11b8cc into main Oct 6, 2021
@peterdudfield peterdudfield deleted the bug/197-topo-gcs branch October 6, 2021 12:23
Copy link
Contributor

@JackKelly JackKelly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! LGTM!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Topo data not loading from gcs

3 participants