This repository was archived by the owner on Sep 28, 2023. It is now read-only.
Move Nowcasting-dataset dataloaders/datamodules/BatchML #9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 tasks
peterdudfield
approved these changes
Oct 20, 2021
Collaborator
peterdudfield
left a comment
peterdudfield
left a comment
There was a problem hiding this comment.
This looks rally good. I think there is no new code written right? Just copiied
Collaborator
Author
Yeah, no new code, just copied over. The new stuff is in #7 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
Description
Moves over the new dataset/datamodule/BatchML from nowcasting-dataset to here.
Unblocks #7
Fixes #8
How Has This Been Tested?
Unit tests
Checklist: