Add Absolute Position Encoder #2
Conversation
jacobbieker
force-pushed
the
jacob/position-encoding
branch
from
50d3c36 to
7b677d5
Compare
flowirtz
left a comment
flowirtz
left a comment
There was a problem hiding this comment.
Few smaller comments, but after fixing that LGTM! 👍
Some [tests] fail for the dataloader/datamodule
Are we tracking those anywhere already?
|
|
||
| def normalize_geospatial_coordinates( | ||
| geospatial_coordinates, geospatial_bounds: Dict[str, float], **kwargs | ||
| geospatial_coordinates: List[np.ndarray], geospatial_bounds: Dict[str, float], **kwargs |
Co-authored-by: Flo <[email protected]>
Co-authored-by: Flo <[email protected]>
No, not right now, it seems like some changes in nowcasting-dataset meant the dataloading code I copied from SatFlow fails. Since nowcasting-dataset is still changing quite a bit with openclimatefix-archives/nowcasting_dataset#213 I was going with sorta waiting till that's more finished to fix the tests. I'll make pytest skip them actually for now |
I'll be making these tests pass as part of #7 |
JackKelly
left a comment
JackKelly
left a comment
There was a problem hiding this comment.
Looks really great to me! Very nicely structured code - easy to read!
A few comments, mostly pretty small!
|
|
||
|
|
||
| def encode_modalities( | ||
| modalities_to_encode: Dict[str, torch.Tensor], |
There was a problem hiding this comment.
I wonder if we should use an Enum for modality names, instead of strings? I'll start a new issue: #15
Co-authored-by: Jack Kelly <[email protected]>
Co-authored-by: Jack Kelly <[email protected]>
Co-authored-by: Jack Kelly <[email protected]>
Co-authored-by: Jack Kelly <[email protected]>
…cob/position-encoding
Co-authored-by: Jack Kelly <[email protected]>
…cob/position-encoding
Pull Request
Description
Moved from openclimatefix-archives/nowcasting_utils#33
Adds positional encoders for:
It is generated using Fourier Features for now, although other options could include coordinates, such as CoordConv or others.
Fixes #4
How Has This Been Tested?
Unit Tests, which pass for the encoding. Some fail for the dataloader/datamodule, but that's unrelated to this
Checklist: