-
Notifications
You must be signed in to change notification settings - Fork 51
v4.10.0 - Add additional properties to annotations #586
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
… ID builder for variants. add variantID to additional properties output. add VCVs to RCV and SCV entries
| if (!hasSCVIds) { | ||
| properties.add(new Property(null, SCVIDS, String.join(",", scvAccessions))); | ||
| } | ||
| getTraitAssociation(variantAnnotation, vcvId).setAdditionalProperties(properties); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@julie-sullivan this line should not be needed
| private static final String PHASE_DATA_URL_SEPARATOR = "\\+"; | ||
| private static final String VARIANT_STRING_FORMAT = "\\+"; | ||
|
|
||
| private Variant parseVariant(String variantString) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is this method being used anywhere?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nope. copy paste error! removed.
| } | ||
|
|
||
| @Test | ||
| public void testKPVPMNVs() throws Exception { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Avoid using "KPVP" in names etc. it's a very internal GeL acronym :)
|
merged into new v4.10.0 branch. |
There are two changes in this PR.
ClinVar - add associated scvIds, vcvIds, rcvIds to additional properties
MNVs - other variants considered as part of phased MNV annotation