Skip to content

Conversation

@julie-sullivan
Copy link
Collaborator

There are two changes in this PR.

ClinVar - add associated scvIds, vcvIds, rcvIds to additional properties

// for VCV records
additionalProperties: [
    ...,
   {
     "name": "scvIds",
     "value": "SCV00403947,SCV00403949,SCV0040393423434"
   }
]

// for SCV records
additionalProperties: [
   ...,
   {
     "name": "vcvIds",
     "value": "39478"
   }
]

MNVs - other variants considered as part of phased MNV annotation

// variant additionalAttributes
"additionalAttributes": {
    "phasedTranscripts": {
        "attribute": {             
            "ENST0034245234": "1:343423:C:G,1:343423:CA:G",
            "ENST0034245236": "1:343423:C:G,1:343423:CA:G",   
            "ENST0034245237": "1:343423:C:G",
        }
    }
}

… ID builder for variants. add variantID to additional properties output. add VCVs to RCV and SCV entries
@julie-sullivan julie-sullivan requested a review from javild May 11, 2022 08:22
@julie-sullivan julie-sullivan self-assigned this May 11, 2022
if (!hasSCVIds) {
properties.add(new Property(null, SCVIDS, String.join(",", scvAccessions)));
}
getTraitAssociation(variantAnnotation, vcvId).setAdditionalProperties(properties);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@julie-sullivan this line should not be needed

private static final String PHASE_DATA_URL_SEPARATOR = "\\+";
private static final String VARIANT_STRING_FORMAT = "\\+";

private Variant parseVariant(String variantString) {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this method being used anywhere?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nope. copy paste error! removed.

}

@Test
public void testKPVPMNVs() throws Exception {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Avoid using "KPVP" in names etc. it's a very internal GeL acronym :)

@julie-sullivan
Copy link
Collaborator Author

merged into new v4.10.0 branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants