Added support of follow HTTP redirects #724
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
expobrain
force-pushed
the
follow_redirect
branch
from
c2f4115 to
2b5a403
Compare
expobrain
force-pushed
the
follow_redirect
branch
from
2b5a403 to
3bb99c7
Compare
emann
previously approved these changes
Mar 20, 2023
There was a problem hiding this comment.
LGTM, although there are some tests failing after merging in main. @expobrain seems like its just output mismatch, can you take a look?
|
Note: This is very much so needed as httpx >=0.20.0 has disabled following redirects by default. |
Codecov Report
@@ Coverage Diff @@
## main #724 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 49 49
Lines 1971 1971
=========================================
Hits 1971 1971 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
Probably will be a breaking change whenever we get around to #202, but this is great for now. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.