fix: Treat leading underscore as a sign of invalid identifier #703
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxkomarychev
force-pushed
the
max/underscore
branch
2 times, most recently
from
f245dfb to
b26be85
Compare
maxkomarychev
changed the title
|
👍 |
dbanty
added
✨ enhancement
There are 2 reasons for this change: - leading underscores have special meaning and therefore we should prefix those properties to avoid unexpected semantics - in my particular use case my team is working with a schema which has the following fields in an object: "field" and "_field" and current code strips leading underscore and produces invalid data object with 2 fields of the same name
maxkomarychev
force-pushed
the
max/underscore
branch
from
b26be85 to
ca38c62
Compare
|
I've fixed linter problems, could you please approve workflows again? Thanks! |
Codecov Report
@@ Coverage Diff @@
## main #703 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 49 49
Lines 1969 1969
=========================================
Hits 1969 1969
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
Hi, when can this be accepted? Are there any outstanding issues with this contribution? Looking forward for the feedback! |
|
I think I was just waiting to merge some other fixes before releasing a new breaking version... but honestly, I don't remember anymore 😅. |
|
FYI @jselig-rigetti I think this is relevant to you 😁 |
dbanty
added a commit
that referenced
this pull request
Jan 6, 2023
…. Thanks @maxkomarychev! Co-authored-by: Dylan Anthony <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are 2 reasons for this change: