Skip to content

Conversation

supermihi
Copy link
Contributor

Without this change, it is very hard for users to trace what actually caused the parsing error.

@supermihi supermihi force-pushed the add-parseerror-detail branch from b0c5e1b to 8ed27da Compare August 26, 2022 09:06
Copy link
Collaborator

@dbanty dbanty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds like a good usability fix, thanks! (And thanks for all the other PRs 🤩)

@codecov
Copy link

codecov bot commented Aug 27, 2022

Codecov Report

Merging #659 (50e40a4) into main (4f9f03a) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##              main      #659   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           49        49           
  Lines         1794      1795    +1     
=========================================
+ Hits          1794      1795    +1     
Impacted Files Coverage Δ
openapi_python_client/parser/openapi.py 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@dbanty dbanty added the ✨ enhancement New feature or improvement label Aug 27, 2022
@dbanty dbanty added this to the 0.11.6 milestone Aug 27, 2022
@dbanty dbanty merged commit 0a0d44b into openapi-generators:main Aug 27, 2022
@supermihi
Copy link
Contributor Author

Welcome, thanks for merging! :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✨ enhancement New feature or improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants