Skip to content

Conversation

dbanty
Copy link
Collaborator

@dbanty dbanty commented May 2, 2021

Reported by @seeM in #305.

@dbanty dbanty added this to the 0.9.0 milestone May 2, 2021
@dbanty dbanty requested a review from emann May 2, 2021 16:43
@codecov
Copy link

codecov bot commented May 2, 2021

Codecov Report

Merging #406 (63298f1) into main (890411a) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##              main      #406   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           46        47    +1     
  Lines         1531      1549   +18     
=========================================
+ Hits          1531      1549   +18     
Impacted Files Coverage Δ
openapi_python_client/parser/openapi.py 100.00% <100.00%> (ø)
...penapi_python_client/parser/properties/property.py 100.00% <100.00%> (ø)
openapi_python_client/schema/__init__.py 100.00% <100.00%> (ø)
...on_client/schema/openapi_schema_pydantic/header.py 100.00% <100.00%> (ø)
...client/schema/openapi_schema_pydantic/parameter.py 100.00% <100.00%> (ø)
openapi_python_client/schema/parameter_location.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 890411a...63298f1. Read the comment docs.

@dbanty dbanty added the 🐞bug Something isn't working label May 2, 2021
@dbanty dbanty linked an issue May 2, 2021 that may be closed by this pull request
Copy link
Collaborator

@emann emann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't super love the fact that the first duplicate-named parameter that is processed gets the name python_name and the others are python_name_where_it_is - better for all of them to be explicit IMO. I made a suggestion for how it could be done, LMK what you think.

@dbanty dbanty requested a review from emann May 3, 2021 17:23
@dbanty dbanty merged commit cdc0d8c into main May 4, 2021
@dbanty dbanty deleted the enforce-unique-endpoint-params branch May 4, 2021 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐞bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SyntaxError: Parameters with the same name but different locations
2 participants