Skip to content

Added ability to generate clients with no metadata or setup.py #275

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 5, 2021

Conversation

dbanty
Copy link
Collaborator

@dbanty dbanty commented Dec 20, 2020

Adds --meta option to the cli (defaulting to "poetry") which will allow generation of a setup.py (--meta=setup) or omitting the top-level altogether and just generating a consumable module (--meta=none).

Closes #120.

I don't use setup.py in my day to day, so I used this as a template and just filled in the blanks. If someone who uses that format more (@dtkav maybe?) could take a look that'd be great.

Also CC @pawamoy and @TMiguelT who were interested parties in this ticket.

@dbanty dbanty requested a review from emann December 20, 2020 21:03
emann
emann previously approved these changes Dec 21, 2020
@codecov
Copy link

codecov bot commented Dec 21, 2020

Codecov Report

Merging #275 (73c99e9) into main (3ca219c) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##              main      #275   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           46        46           
  Lines         1314      1348   +34     
=========================================
+ Hits          1314      1348   +34     
Impacted Files Coverage Δ
openapi_python_client/__init__.py 100.00% <100.00%> (ø)
openapi_python_client/cli.py 100.00% <100.00%> (ø)
...penapi_python_client/parser/properties/__init__.py 100.00% <100.00%> (ø)
...penapi_python_client/parser/properties/property.py 100.00% <100.00%> (ø)
openapi_python_client/parser/reference.py 100.00% <100.00%> (ø)
openapi_python_client/utils.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update caecb03...73c99e9. Read the comment docs.

@emann emann self-requested a review December 22, 2020 15:35
emann
emann previously approved these changes Dec 22, 2020
@dbanty
Copy link
Collaborator Author

dbanty commented Jan 5, 2021

@bowenwr does anyone on your team want to review this before I merge it?

@bowenwr
Copy link
Contributor

bowenwr commented Jan 5, 2021

@bowenwr does anyone on your team want to review this before I merge it?

Thanks for asking, I wouldn't block on review from us! Cursory glance looks good.

@dbanty dbanty merged commit 5625dde into main Jan 5, 2021
@dbanty dbanty deleted the issue-120-metadata-options branch January 5, 2021 21:39
@dbanty dbanty added this to the 0.8.0 milestone Jan 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add option to generate clients without Poetry
3 participants