-
-
Notifications
You must be signed in to change notification settings - Fork 228
feat: allow Ruff 0.11 #1222
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
feat: allow Ruff 0.11 #1222
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
dbanty
approved these changes
Mar 15, 2025
github-merge-queue bot
pushed a commit
that referenced
this pull request
Mar 15, 2025
> [!IMPORTANT] > Merging this pull request will create this release ## Features - allow Ruff to 0.10 (#1220) - allow Ruff 0.11 (#1222) - Allow any `Mapping` in generated `from_dict` functions (#1211) ## Fixes ### Always parse `$ref` as a reference If additional attributes were included with a `$ref` (for example `title` or `description`), the property could be interpreted as a new type instead of a reference, usually resulting in `Any` in the generated code. Now, any sibling properties to `$ref` will properly be ignored, as per the OpenAPI specification. Thanks @nkrishnaswami! Co-authored-by: knope-bot[bot] <152252888+knope-bot[bot]@users.noreply.github.com>
micha91
pushed a commit
to micha91/openapi-python-client
that referenced
this pull request
May 13, 2025
This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [ruff](https://docs.astral.sh/ruff) ([source](https://redirect.github.com/astral-sh/ruff), [changelog](https://redirect.github.com/astral-sh/ruff/blob/main/CHANGELOG.md)) | `>=0.2,<0.11` -> `>=0.2,<0.12` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>astral-sh/ruff (ruff)</summary> ### [`v0.11.0`](https://redirect.github.com/astral-sh/ruff/blob/HEAD/CHANGELOG.md#0110) [Compare Source](https://redirect.github.com/astral-sh/ruff/compare/0.10.0...0.11.0) This is a follow-up to release 0.10.0. Because of a mistake in the release process, the `requires-python` inference changes were not included in that release. Ruff 0.11.0 now includes this change as well as the stabilization of the preview behavior for `PGH004`. ##### Breaking changes - **Changes to how the Python version is inferred when a `target-version` is not specified** ([#​16319](https://redirect.github.com/astral-sh/ruff/pull/16319)) In previous versions of Ruff, you could specify your Python version with: - The `target-version` option in a `ruff.toml` file or the `[tool.ruff]` section of a pyproject.toml file. - The `project.requires-python` field in a `pyproject.toml` file with a `[tool.ruff]` section. These options worked well in most cases, and are still recommended for fine control of the Python version. However, because of the way Ruff discovers config files, `pyproject.toml` files without a `[tool.ruff]` section would be ignored, including the `requires-python` setting. Ruff would then use the default Python version (3.9 as of this writing) instead, which is surprising when you've attempted to request another version. In v0.10, config discovery has been updated to address this issue: - If Ruff finds a `ruff.toml` file without a `target-version`, it will check for a `pyproject.toml` file in the same directory and respect its `requires-python` version, even if it does not contain a `[tool.ruff]` section. - If Ruff finds a user-level configuration, the `requires-python` field of the closest `pyproject.toml` in a parent directory will take precedence. - If there is no config file (`ruff.toml`or `pyproject.toml` with a `[tool.ruff]` section) in the directory of the file being checked, Ruff will search for the closest `pyproject.toml` in the parent directories and use its `requires-python` setting. ##### Stabilization The following behaviors have been stabilized: - [`blanket-noqa`](https://docs.astral.sh/ruff/rules/blanket-noqa/) (`PGH004`): Also detect blanked file-level noqa comments (and not just line level comments). ##### Preview features - \[syntax-errors] Tuple unpacking in `for` statement iterator clause before Python 3.9 ([#​16558](https://redirect.github.com/astral-sh/ruff/pull/16558)) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR was generated by [Mend Renovate](https://mend.io/renovate/). View the [repository job log](https://developer.mend.io/github/openapi-generators/openapi-python-client). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOS4yMDAuMCIsInVwZGF0ZWRJblZlciI6IjM5LjIwMC4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6W119--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
micha91
pushed a commit
to micha91/openapi-python-client
that referenced
this pull request
May 13, 2025
> [!IMPORTANT] > Merging this pull request will create this release ## Features - allow Ruff to 0.10 (openapi-generators#1220) - allow Ruff 0.11 (openapi-generators#1222) - Allow any `Mapping` in generated `from_dict` functions (openapi-generators#1211) ## Fixes ### Always parse `$ref` as a reference If additional attributes were included with a `$ref` (for example `title` or `description`), the property could be interpreted as a new type instead of a reference, usually resulting in `Any` in the generated code. Now, any sibling properties to `$ref` will properly be ignored, as per the OpenAPI specification. Thanks @nkrishnaswami! Co-authored-by: knope-bot[bot] <152252888+knope-bot[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains the following updates:
>=0.2,<0.11
->>=0.2,<0.12
Release Notes
astral-sh/ruff (ruff)
v0.11.0
Compare Source
This is a follow-up to release 0.10.0. Because of a mistake in the release process, the
requires-python
inference changes were not included in that release. Ruff 0.11.0 now includes this change as well as the stabilization of the preview behavior forPGH004
.Breaking changes
Changes to how the Python version is inferred when a
target-version
is not specified (#16319)In previous versions of Ruff, you could specify your Python version with:
target-version
option in aruff.toml
file or the[tool.ruff]
section of a pyproject.toml file.project.requires-python
field in apyproject.toml
file with a[tool.ruff]
section.These options worked well in most cases, and are still recommended for fine control of the Python version. However, because of the way Ruff discovers config files,
pyproject.toml
files without a[tool.ruff]
section would be ignored, including therequires-python
setting. Ruff would then use the default Python version (3.9 as of this writing) instead, which is surprising when you've attempted to request another version.In v0.10, config discovery has been updated to address this issue:
ruff.toml
file without atarget-version
, it will checkfor a
pyproject.toml
file in the same directory and respect itsrequires-python
version, even if it does not contain a[tool.ruff]
section.
requires-python
field of the closestpyproject.toml
in a parent directory will take precedence.ruff.toml
orpyproject.toml
with a[tool.ruff]
section) in the directory of the file being checked, Ruff willsearch for the closest
pyproject.toml
in the parent directories and use itsrequires-python
setting.Stabilization
The following behaviors have been stabilized:
blanket-noqa
(PGH004
): Also detect blanked file-level noqa comments (and not just line level comments).Preview features
for
statement iterator clause before Python 3.9 (#16558)Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR was generated by Mend Renovate. View the repository job log.