Skip to content

Include all trace export payloads #1349

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 4 commits into from
Closed

Include all trace export payloads #1349

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
ab74ee8
Fix HTTPX timeout and include all export items
mshsheikh Aug 2, 2025
17721a6
Fix HTTPX timeout config and include all trace export payloads
mshsheikh Aug 2, 2025
4d78dc6
Revert explicit httpx timeout config with no behavior change
mshsheikh Aug 2, 2025
5f4bfc6
Revert explicit httpx timeout config with no behavior change
mshsheikh Aug 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/agents/tracing/processors.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,7 +96,8 @@ def export(self, items: list[Trace | Span[Any]]) -> None:
logger.warning("OPENAI_API_KEY is not set, skipping trace export")
return

data = [item.export() for item in items if item.export()]
# include all export() results, even if they’re empty/falsy
data = [item.export() for item in items]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you elaborate more on this? If there is a certain situation to resolve, we're happy to adjust this logic, but we aren't aware of anything.

payload = {"data": data}

headers = {
Expand Down