[TUI] Remove bottom padding #4854
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nornagon-openai
approved these changes
Oct 7, 2025
gpeal
commented
Oct 7, 2025
| expression: terminal.backend() | ||
| --- | ||
| "• Thinking (0s • esc to interrupt) " | ||
| " " |
nornagon-openai
approved these changes
Oct 7, 2025
Comment on lines
733
to
747
| r_last.trim().is_empty(), | ||
| "expected last row blank: {r_last:?}" | ||
| composer_found, | ||
| "expected composer placeholder to be rendered with the status widget active" | ||
| ); |
There was a problem hiding this comment.
i think this would be better as a snapshot test, it's quite hard to understand what this is testing
There was a problem hiding this comment.
@codex replace this with a snapshot test
There was a problem hiding this comment.
Summary
- Replaced manual buffer assertions in the bottom pane height regression tests with reusable insta snapshot helpers to make the expectations clearer. codex-rs/tui/src/bottom_pane/mod.rsL522-L546 codex-rs/tui/src/bottom_pane/mod.rsL722-L761
- Added dedicated snapshots that capture the full-height layout as well as the height-2 and height-1 collapse scenarios for the bottom pane. codex-rs/tui/src/bottom_pane/snapshots/codex_tui__bottom_pane__tests__status_and_composer_fill_height_without_bottom_padding.snapL1-L11 codex-rs/tui/src/bottom_pane/snapshots/codex_tui__bottom_pane__tests__status_hidden_when_height_too_small_height_2.snapL1-L6 codex-rs/tui/src/bottom_pane/snapshots/codex_tui__bottom_pane__tests__status_hidden_when_height_too_small_height_1.snapL1-L5
Testing
⚠️ just fmt(prints nightly-only warning noise from cargo fmt)- ✅
cargo test -p codex-tui
codex-rs/tui/src/bottom_pane/mod.rs
Outdated
Comment on lines
780
to
783
| assert!( | ||
| row0.contains("Working") || row1.contains("Working"), | ||
| "expected status header to be visible at height=2: row0={row0:?}, row1={row1:?}" | ||
| !row0.contains("Working") && !row1.contains("Working"), | ||
| "expected status header to collapse at height=2: row0={row0:?}, row1={row1:?}" | ||
| ); |
There was a problem hiding this comment.
this should also be snapshot imo
Comment on lines
-5
to
+6
| "• Thinking (0s • esc to interrupt) " | ||
| " " |
There was a problem hiding this comment.
this seems off, though low-pri as generally we don't care too much about height-2 terminals.
nornagon-openai
approved these changes
Oct 7, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We don't need the bottom padding. It currently just makes the footer look off-centered.
Before:
After:
