Simplify parallel #4829
Merged
Simplify parallel #4829
+58
−114
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@codex give a thorough review, focus on lifetimes of tools call invocations |
|
Codex Review: Didn't find any major issues. 🚀 ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting |
jif-oai
reviewed
Oct 6, 2025
- Replace manual pending call tracking with FuturesOrdered for response processing - Use RwLock and abort-on-drop for tool parallelization, supporting parallel and serial modes - Switch tokio-util dependency to use "rt" feature - Cleanup error handling and streamline handling of tool and non-tool response items
pakrym-oai
force-pushed
the
pakrym/simplify-parallel
branch
from
258b068 to
cbf6ced
Compare
jif-oai
approved these changes
Oct 7, 2025
codex-rs/core/src/tools/parallel.rs
Outdated
| tracker: SharedTurnDiffTracker, | ||
| sub_id: String, | ||
| pending_calls: Vec<PendingToolCall>, | ||
| lock: Arc<RwLock<bool>>, |
There was a problem hiding this comment.
lock is very generic (and even a reserved key word in some languages)
- this looks a bit like a hack. You do not even need the
bool. At least, have an empty lock
| match handle.await { | ||
| Ok(Ok(response)) => Ok(response), | ||
| Ok(Err(FunctionCallError::Fatal(message))) => Err(CodexErr::Fatal(message)), | ||
| Ok(Err(other)) => Err(CodexErr::Fatal(other.to_string())), |
There was a problem hiding this comment.
This will change a bit how the errors bubble. It means that in the serial path, if there is an error, we don't bubble it directly
Find by me but this changes the behaviour so we need to make sure it does not cause any issues
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
make tool processing return a future and then collect futures.
handle cleanup on Drop