This repository was archived by the owner on Oct 25, 2024. It is now read-only.
Subscribed streams are associated with subscriptions. #488
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jianjunz
added
comp:conference
jianjunz
force-pushed
the
sub-stream
branch
3 times, most recently
from
1290482 to
5d212dc
Compare
taste1981
reviewed
Apr 23, 2021
src/sdk/conference/channel.js
Outdated
| this._sdpResolverMap = new Map(); // internalId => {finish, resolve, reject} | ||
| this._sdpResolvers = []; // [{finish, resolve, reject}] | ||
| this._sdpResolveNum = 0; | ||
| this._remoteMediaStream = new Map(); // Key is subscription ID, value is MediaStream. |
Collaborator
There was a problem hiding this comment.
this._remoteMediaStreams instead of this._remoteMediaStream
When subscribe a stream in conference mode, the subscribed stream no longer associated with RemoteStream. It allows a RemoteStream to be subscribed multiple times. It also allows a subscription has audio and video track from different remote streams. Since the signaling protocol defined by server side does not provide an ID for a track, the SDK usually use stream ID + track kind to identify a track. The stream ID and track ID mentioned in conference mode indicate the ID assigned by conference sever, they could be different from MediaStream ID and MediaStreamTrack ID.
taste1981
approved these changes
Apr 25, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When subscribe a stream in conference mode, the subscribed stream no
longer associated with RemoteStream. It allows a RemoteStream to be
subscribed multiple times. It also allows a subscription has audio and
video track from different remote streams.
Since the signaling protocol defined by server side does not provide an
ID for a track, the SDK usually use stream ID + track kind to identify a
track. The stream ID and track ID mentioned in conference mode indicate
the ID assigned by conference sever, they could be different from
MediaStream ID and MediaStreamTrack ID.