This repository was archived by the owner on Oct 25, 2024. It is now read-only.
Send localDescription, not local variable #487
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jianjunz
approved these changes
Apr 21, 2021
Collaborator
jianjunz
left a comment
jianjunz
left a comment
There was a problem hiding this comment.
Thanks for your change.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sending the argument passed to setLocalDescription() is not always the correct thing to do, if there are new offers incoming or a rollback occurred. Instead, send the PeerConnection's localDescription (not current or pending, PeerConnection knows which to use)