Skip to content

fix schema_url constants in semconv #4069

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Jul 22, 2024
Merged

fix schema_url constants in semconv #4069

Show file tree
Hide file tree
Changes from 6 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
886d912
fix schema url
emdneto Jul 22, 2024
5792fc9
add changelog
emdneto Jul 22, 2024
cdfcedd
Update opentelemetry-semantic-conventions/src/opentelemetry/semconv/s…
emdneto Jul 22, 2024
6cdcb38
Update opentelemetry-semantic-conventions/src/opentelemetry/semconv/s…
emdneto Jul 22, 2024
8bde1f5
fix spelling
emdneto Jul 22, 2024
a34c284
fix spelling
emdneto Jul 22, 2024
7e8cde2
fix generate semconv script
emdneto Jul 22, 2024
649a719
Merge branch 'main' into fix/semconv
lzchen Jul 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,6 +52,8 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
([#3991](https://github.com/open-telemetry/opentelemetry-python/pull/3991))
- Add attributes field in `MeterProvider.get_meter` and `InstrumentationScope`
([#4015](https://github.com/open-telemetry/opentelemetry-python/pull/4015))
- Fix inaccessible `SCHEMA_URL` constants in `opentelemetry-semantic-conventions`
([#4069](https://github.com/open-telemetry/opentelemetry-python/pull/4069))

## Version 1.25.0/0.46b0 (2024-05-30)

Expand Down
2 changes: 1 addition & 1 deletion opentelemetry-semantic-conventions/src/opentelemetry/semconv/metrics/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@
reason="Use metrics defined in the :py:const:`opentelemetry.semconv.metrics` and :py:const:`opentelemetry.semconv._incubating.metrics` modules instead.",
) # type: ignore
class MetricInstruments:
SCHEMA_URL = "https://opentelemetry.io/schemas/v1.21.0"
SCHEMA_URL = "https://opentelemetry.io/schemas/1.21.0"
"""
The URL of the OpenTelemetry schema for these keys and values.
"""
Expand Down
2 changes: 1 addition & 1 deletion opentelemetry-semantic-conventions/src/opentelemetry/semconv/resource/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@
reason="Use attributes defined in the :py:const:`opentelemetry.semconv.attributes` and :py:const:`opentelemetry.semconv._incubating.attributes` modules instead.",
) # type: ignore
class ResourceAttributes:
SCHEMA_URL = "https://opentelemetry.io/schemas/v1.21.0"
SCHEMA_URL = "https://opentelemetry.io/schemas/1.21.0"
"""
The URL of the OpenTelemetry schema for these keys and values.
"""
Expand Down
8 changes: 4 additions & 4 deletions opentelemetry-semantic-conventions/src/opentelemetry/semconv/schemas.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,14 +21,14 @@ class Schemas(Enum):
The URL of the OpenTelemetry schema version 1.23.1.
"""

V1_25_0 = "https://opentelemetry.io/schemas/v1.25.0"
V1_25_0 = "https://opentelemetry.io/schemas/1.25.0"
"""
The URL of the OpenTelemetry schema version v1.25.0.
The URL of the OpenTelemetry schema version 1.25.0.
"""

V1_26_0 = "https://opentelemetry.io/schemas/v1.26.0"
V1_26_0 = "https://opentelemetry.io/schemas/1.26.0"
"""
The URL of the OpenTelemetry schema version v1.26.0.
The URL of the OpenTelemetry schema version 1.26.0.
"""

# when generating new semantic conventions,
Expand Down
2 changes: 1 addition & 1 deletion opentelemetry-semantic-conventions/src/opentelemetry/semconv/trace/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@
reason="Use attributes defined in the :py:const:`opentelemetry.semconv.attributes` and :py:const:`opentelemetry.semconv._incubating.attributes` modules instead.",
) # type: ignore
class SpanAttributes:
SCHEMA_URL = "https://opentelemetry.io/schemas/v1.21.0"
SCHEMA_URL = "https://opentelemetry.io/schemas/1.21.0"
"""
The URL of the OpenTelemetry schema for these keys and values.
"""
Expand Down