sdk: try to make test_batch_span_processor_reset_timeout a bit less flaky #3937
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…laky If the BatchSpanProcessor has not processed its queue test will fail with: UnboundLocalError: local variable 'after_calls' referenced before assignment So double the sleep to more than the schedule_delay_millis to give it more room. Fix open-telemetry#3936
tammy-baylis-swi
approved these changes
May 30, 2024
ocelotl
suggested changes
May 30, 2024
ocelotl
approved these changes
May 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
If the BatchSpanProcessor has not processed its queue test will fail with:
UnboundLocalError: local variable 'after_calls' referenced before assignment
So double the sleep to more than the schedule_delay_millis to give it more room.
Fixes #3936
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Does This PR Require a Contrib Repo Change?
Checklist: