Add 3.12 to tox #3616
Merged
Add 3.12 to tox #3616
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jeremydvoss this should now work if rebased on main |
|
Great, rebased ✌️ |
xrmx
reviewed
Apr 23, 2024
|
Im desperate for this merge 😭 |
|
@jeremydvoss I added some missing changes to complete this PR, do you think we can move forward with this PR? |
ocelotl
approved these changes
May 15, 2024
xrmx
approved these changes
May 16, 2024
jeremydvoss
commented
May 16, 2024
jeremydvoss
added
PR:please merge
|
BTW this require a similar PR in contrib before release right? |
|
MArking it as draft to prevent merging while I look into 3.12 for the contrib repo. |
|
Still one test failing. I'll repush and see if it's transient |
|
Rebased and pushed. |
lzchen
approved these changes
Jun 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add tox 3.12 support
Does This PR Require a Contrib Repo Change?
open-telemetry/opentelemetry-python-contrib#2572