Update the body type in the log #3343
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
shalevr
reviewed
Jun 13, 2023
opentelemetry-sdk/src/opentelemetry/sdk/_logs/_internal/__init__.py
Outdated
Show resolved
Hide resolved
|
Can you please add a test to be clear about which cases you want to correct |
All right, I will include test cases. |
ocelotl
reviewed
Jun 28, 2023
opentelemetry-sdk/src/opentelemetry/sdk/_logs/_internal/__init__.py
Outdated
Show resolved
Hide resolved
srikanthccv
approved these changes
Jul 5, 2023
7 tasks
pR0Ps
added a commit
to pR0Ps/opentelemetry-python
that referenced
this pull request
Oct 25, 2024
Mostly a revert of open-telemetry#3343
pR0Ps
added a commit
to pR0Ps/opentelemetry-python
that referenced
this pull request
Nov 27, 2024
Mostly a revert of open-telemetry#3343
pR0Ps
added a commit
to pR0Ps/opentelemetry-python
that referenced
this pull request
Nov 27, 2024
Mostly a revert of open-telemetry#3343
pR0Ps
added a commit
to pR0Ps/opentelemetry-python
that referenced
this pull request
Nov 27, 2024
Mostly a revert of open-telemetry#3343
7 tasks
pR0Ps
added a commit
to pR0Ps/opentelemetry-python
that referenced
this pull request
Dec 6, 2024
Mostly a revert of open-telemetry#3343
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
According to the definition of the Body field type in the OTel 1.22.0 Logs Data Model article, the Body field should be of type 'any' and should not use the str method to directly translate the msg. This is because str only converts non-text types into a human-readable form, rather than a standard format, which leads to the need for additional operations when collected through a log collector.
Type of change
Checklist: