Skip to content

Conversation

shalevr
Copy link
Member

@shalevr shalevr commented Jun 11, 2023

Description

Add unit to view instrument selection criteria

Fixes #3263

Type of change

  • New feature (non-breaking change which adds functionality)

Checklist:

  • Followed the style guidelines of this project
  • Changelogs have been updated
  • Unit tests have been added
  • Documentation has been updated

@shalevr shalevr requested a review from a team June 11, 2023 07:31
@shalevr shalevr marked this pull request as draft June 11, 2023 07:31
@shalevr
Copy link
Member Author

shalevr commented Jun 11, 2023

I will update the spec-compliance-matrix.md after the merge

@shalevr shalevr force-pushed the add-unit-to-view-instrument branch from e0b9210 to 43deca2 Compare June 11, 2023 08:29
@shalevr shalevr force-pushed the add-unit-to-view-instrument branch from 43deca2 to 5dc8f4b Compare June 11, 2023 08:32
@shalevr shalevr marked this pull request as ready for review June 11, 2023 09:10
Copy link
Member

@srikanthccv srikanthccv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@shalevr shalevr added the PR:please merge This PR is ready to be merged by a Maintainer (has enough valid approvals, successful build, etc.) label Jun 23, 2023
@ocelotl ocelotl merged commit 9026027 into open-telemetry:main Jun 26, 2023
carlosalberto pushed a commit to open-telemetry/opentelemetry-specification that referenced this pull request Jul 5, 2023
Added Python support for "The View instrument selection criteria
supports a unit."

According to
open-telemetry/opentelemetry-python#3341
carlosalberto pushed a commit to carlosalberto/opentelemetry-specification that referenced this pull request Oct 31, 2024
Added Python support for "The View instrument selection criteria
supports a unit."

According to
open-telemetry/opentelemetry-python#3341
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR:please merge This PR is ready to be merged by a Maintainer (has enough valid approvals, successful build, etc.)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

View instrument selection criteria should accept unit
4 participants