Skip to content

Make Sphinx check for undefined references & .gitignore _build. #32

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 27, 2019
Merged

Make Sphinx check for undefined references & .gitignore _build. #32

merged 1 commit into from
Jun 27, 2019

Conversation

Oberon00
Copy link
Member

The intersphinx_mapping is required to avoid warnings about things like typing.Iterator, I think it's neat anyway to have these linked.

@Oberon00 Oberon00 requested review from reyang and c24t June 26, 2019 14:06
@Oberon00 Oberon00 requested a review from carlosalberto as a code owner June 26, 2019 14:06
@Oberon00 Oberon00 self-assigned this Jun 26, 2019
@Oberon00 Oberon00 added the meta Related to repo itself, process, community, ... label Jun 26, 2019
c24t
c24t approved these changes Jun 27, 2019
View reviewed changes
Copy link
Member

@c24t c24t left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Oberon00 Oberon00 merged commit d7d9907 into open-telemetry:master Jun 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@reyang reyang reyang approved these changes

@carlosalberto carlosalberto Awaiting requested review from carlosalberto

+1 more reviewer

@c24t c24t c24t approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@Oberon00 Oberon00

Labels
meta Related to repo itself, process, community, ...
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Oberon00 @reyang @c24t