-
Notifications
You must be signed in to change notification settings - Fork 744
Implement shutdown procedure for OTLP grpc exporters #3138
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
3a91378
8bca278
d81f35f
8be9803
b92d2fa
a229f6a
b2e75cf
c512fc9
d8b7ec0
b26c186
05c62d5
ca2cf37
6b9d10b
75b10c8
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -290,6 +290,9 @@ def _translate_data( | |
def export(self, spans: Sequence[ReadableSpan]) -> SpanExportResult: | ||
return self._export(spans) | ||
|
||
def shutdown(self) -> None: | ||
OTLPExporterMixin.shutdown(self) | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @girishc13 Can you please help me understand why you are calling There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I don't remember the exact details but the There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I think the issue maybe due to mixin inheritance being applied incorrectly, currently we have class OTLPSpanExporter(SpanExporter, OTLPExporterMixin[...]): but usually in python mixin should come before the base class, e.g. class OTLPSpanExporter(OTLPExporterMixin[...], SpanExporter): this way, |
||
|
||
def force_flush(self, timeout_millis: int = 30000) -> bool: | ||
return True | ||
|
||
|
Uh oh!
There was an error while loading. Please reload this page.