Add setuptools runtime requirement #2334
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `pkg_resources` module is provided by `setuptools`. The `setuptools` package is not part of the Python stdlib but is often available in the system environment as a build-time requirement. Explicitly listing `setuptools` as a requirement protects `opentelemetry-python` from breaking with import errors in cases where `setuptools` is not available system-wide. This commit pins the version to `setuptools >= 16.0` which is the first release that includes the required imports (2015).
mattoberle
force-pushed
the
issue/2282
branch
from
70ff208 to
7f6ab5b
Compare
owais
reviewed
Dec 21, 2021
owais
approved these changes
Dec 21, 2021
srikanthccv
approved these changes
Dec 23, 2021
jenshnielsen
added a commit
to jenshnielsen/opentelemetry-python
that referenced
this pull request
Jul 6, 2023
This was originally added in open-telemetry#2334 but the runtime dependency on pkg_resources was since dropped in open-telemetry#3047 so the dependency can be dropped
7 tasks
jenshnielsen
added a commit
to jenshnielsen/opentelemetry-python
that referenced
this pull request
Jul 6, 2023
This was originally added in open-telemetry#2334 but the runtime dependency on pkg_resources was since dropped in open-telemetry#3047 so the dependency can be dropped
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The
pkg_resourcesmodule is provided bysetuptools.The
setuptoolspackage is not part of the Python stdlib but is often available in the system environment as a build-time requirement.Explicitly listing
setuptoolsas a requirement protectsopentelemetry-pythonfrom breaking with import errors in cases wheresetuptoolsis not available system-wide.This commit pins the version to
setuptools >= 16.0which is the first release that includes the required imports (2015).A similar change was adopted in opentelemetry-python-contrib.
Fixes #2282
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
mkdir /tmp/pkg && pip install -t /tmp/pkg {modified-pkg} && test -f /tmp/pkg/pkg_resourcesDoes This PR Require a Contrib Repo Change?
Checklist: